Date: Wed, 23 Mar 2016 09:42:49 -0700
From: "W. Trevor King" <wking@tremily.us>
To: David Bremner <david@tethera.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v2 2/4] nmbug-status: Add meta.message-url config setting
Message-ID: <20160323164249.GX10674@odin.tremily.us>
References: <cover.1451683912.git.wking@tremily.us>
 <9377a4c1265b13f9588d21ec0ea591ea9f61a05f.1451683912.git.wking@tremily.us>
 <87zitpjvax.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="9/9WPmgm2v60RN0g"
Content-Disposition: inline
In-Reply-To: <87zitpjvax.fsf@zancas.localnet>
OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;
 url=http://tremily.us/pubkey.txt
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: list


--9/9WPmgm2v60RN0g
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 23, 2016 at 08:19:34AM -0300, David Bremner wrote:
> W. Trevor King writes:
> >  from __future__ import print_function
> > @@ -232,6 +232,10 @@ class Page (object):
> >  class HtmlPage (Page):
> >      _slug_regexp =3D re.compile('\W+')
> >
> > +    def __init__(self, message_url_template, **kwargs):
> > +        self.message_url_template =3D message_url_template
> > +        super(HtmlPage, self).__init__(**kwargs)
> > +
>
> > @@ -395,6 +400,8 @@ _PAGES['text'] =3D Page()
> >  _PAGES['html'] =3D HtmlPage(
> >      header=3Dheader_template.format(**context),
> >      footer=3Dfooter_template.format(**context),
> > +    message_url_template=3Dconfig['meta'].get(
> > +        'message-url', 'http://mid.gmane.org/{message-id}'),
> >      )
> >
>
> Maybe I'm missing some python knowledged, but it looks the
> constructor is defined to take a regular argument for
> message_url_template, but only passed in as a keyword. Does this
> really work?

Yup.  From [1]:

  positional-only: specifies an argument that can be supplied only by
    position. Python has no syntax for defining positional-only
    parameters. However, some built-in functions have positional-only
    parameters (e.g. abs()).

I can't find a similar Python 3 glossary, but see [2].  Whether we use:

  def __init__(self, message_url_template, **kwargs):
      =E2=80=A6

or:

  def __init__(self, message_url_template=3D'foobar', **kwargs):
      =E2=80=A6

just controls whether the message_url_template has a default or not,
and not whether it can be set via positional or keyword arguments.

There is Python syntax for keyword-only arguments, and it would look
like [2]:

  def __init__(self, *, message_url_template, **kwargs):
      =E2=80=A6

or:

  def __init__(self, *, message_url_template=3D'foobar', **kwargs):
      =E2=80=A6

in the former case, you'd have to call __init__ with a
message_url_template=3D=E2=80=A6 keyword argument or you'd get:

  TypeError: __init__() missing 1 required keyword-only argument: 'message_=
url_template'

With the latter case, calling __init__ without a message_url_template
argument would just get you the default value (=E2=80=98foobar=E2=80=99 in =
these
examples).

Cheers,
Trevor

[1]: https://docs.python.org/2/glossary.html#term-parameter
[2]: https://docs.python.org/3/reference/compound_stmts.html#function-defin=
itions

--=20
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

--9/9WPmgm2v60RN0g
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJW8seHAAoJEAPqygegUbGs/eAQAJCBVzmrcY+PboKhJP5atwtT
yq3WrENws2uvXLmB9+h7B7NJBRJk6xvefbpWWIsY003lqv0IVDt6c7a8L2JPPfgL
VGr94elPkVCWNu74zYuRVxvHWURqo8167szslI40Fm7fB0d7V7lOFk8soaBEa4lV
jOS6y2zkTubk7o0u92DdmtyiBnOTylbCym8ZhZ7S8sBysoWqr5I7Rh1YXRh7jvfP
/GUIE6ZgbLNCWKA99Z4YMCX1glMLrLedU2SLQM+X2x6IsuIHVMVD8oj6FCj5A2VH
CSjeWNMsMqIaEUinuM5BxKL7Z+N6+W8AuGpd2AQbhEpxGnXUb40JuwRc+F/tDn09
T+oMdSj7x66Ik2bl3Ns0U/YMTOqSl7wL7kzufsm6X7sR6sA75fehSIkFo39hXziQ
rp6lSjZLSgX/seiUs5icXy0G6acKaIT3DEalouA+HdNbc2Tyolp6U+wGX2JJO2/O
WGudLN2bFtUc26VivkKf7FV/QS9XWP6X+VSZ2flWZSpeZQkVIGIca4QSsEcqS3dm
p3eDHi9vdRYGWvsP3HA7YryI+NiIU0FHEIz329M8L9oqpEjB7TzPJsb+iUHcK1q0
Vez4CVXLUEEbumgy4IhPOo7e1cUQh/OEDImr7PrP4naMAreRoFtvVWHywFWziQu3
YDJ/hV9Y1qlxhKb2JIFW
=o4kq
-----END PGP SIGNATURE-----

--9/9WPmgm2v60RN0g--