From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag)
In-Reply-To: <87ty0w50r7.fsf@qmul.ac.uk>
References: <1333716551-29153-1-git-send-email-markwalters1009@gmail.com>
	<87bon47v0o.fsf@servo.finestructure.net>
	<87ty0w50r7.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.12+93~gd54240d (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Fri, 06 Apr 2012 09:19:52 -0700
Message-ID: <877gxs7ryv.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=

On Fri, Apr 06 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> There are some exclude tests for count in test/count. Do you think it
> needs to be a full test everything like in test/search-exclude?

Ah yes.  Somehow I missed that.

I might prefer to keep all exclude tests in one test script.  In which
case it would be good to move the count exclude tests there, and maybe
round it out by testing both exclude options.

> There aren't any tests for show exclude, but there aren't very many
> tests explicitly for show anyway. My preference would be to add
> something like
> id:"1332171061-27983-1-git-send-email-markwalters1009@gmail.com" and add
> some tests to that.

Oh wow I wonder why that hasn't been pushed yet.  That's a bunch of new
good tests.  It's a long changeset, which is probably why there aren't
any reviews, but it's all test additions so we should definitely
fast-track it.  I'll try to look at it this weekend.

> I could add some tests for show-excludes in the same format as the
> search-exclude tests though if you think that is better.

As I mentioned above, I personally think it would nice to test all the
exclude functionality in one test script.  So I would vote for adding
some show exclude tests there.  Definitely doesn't need to be as
exhaustive as the search tests, but at least covering both cli options.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJPfxepAAoJEO00zqvie6q8q9AP/jaBXI13C8YX/GQzxa7YPgdH
yE0tmUVct6IkghiA4mxYDh8Kw/qYuA5MIdAoqphfJF9kQlfOyHHOMaaPTn3fj/Ij
/SXCH11EyDhoTlJKkAJ303/uHCbtbK2JIqBKXFXpQiTbrrb5+6IJw0lWk2y4+4pO
BRVo3zy0Zx2NYrX9hxGmF2G7Fhn6sJNTcbWJTtoP3Oh+TDsd+28R4b0ujJVIm3N4
QjW3QTS3vIAOpyFt1lsvnosRRwPD39fN/Yf5gMR/VobF0v021F/uk+Z16VxgTaWu
Higy4nivYCGn+7IXV8BmmzgYJOyxIIBO0D3cfFsgECnJjOUBFbYtauAm2kGotXrV
8+PgL9Bt3yDR7zTNsVUP6Il8FRNn6n2YOuWXRSKcFfvK8wPP98FOvO/2AeBsHNVW
9/a2Wtor03DRzxPoZhFDvTpqRsIayIauCDvKh19AUT1gdVJod+oJEa+/pzAGbmHP
jxPiQPePeYdvDqym0RWXAMUFdKRXWbTFU0qKKvD3zcwuzNHJiOzo7uV2Sfvzz4xD
Ke8TVuWJxskXyzI/rqMY+c189xH++5uhDqsZy7AY+3WyuMkbDvFkX4Bx48XBEm2O
FKUJ7JunseCYRUEktUvJlawYn/PY95UICoOeCBA8kgFTZievWI7h9JPpowhq+O6z
P6l+uhFFdgNz8/j6BCdB
=pLRB
-----END PGP SIGNATURE-----
--=-=-=--