References: <20110703171743.GL15901@mit.edu>
	<1309762318-4530-1-git-send-email-pieter@praet.org>
User-Agent: K-9 Mail for Android
In-Reply-To: <1309762318-4530-1-git-send-email-pieter@praet.org>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----TNBCPH3ADEBNTKTYUGJVLMN8JRAE0R"
Subject: Re: [PROTO] possible solution for "Race condition for '*' command"
From: Austin Clements <amdragon@MIT.EDU>
Date: Mon, 04 Jul 2011 13:56:26 -0400
To: Pieter Praet <pieter@praet.org>
Message-ID: <e8c5fbf4-4dfa-461a-8f5c-6c696291a270@email.android.com>
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Precedence: list

------TNBCPH3ADEBNTKTYUGJVLMN8JRAE0R
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 8bit

Ah, this is subtler than I thought. You're right that, for the '*' command, you want only the matched ID's. Tagging a region, however, operates on entire threads. I think it's important to retain this behavior because threads are what the user sees and selects in the search buffer (*, on the other hand, doesn't have a strong visual analogue).

(This also means * is not, in fact, equivalent to expanding the region the the entire buffer and then tagging the region.)

I should probably emit two lists per thread: one of matched IDs and one of unmatched IDs. Tagging a region can then operate on the concatenation of these, while * can operate only on the matched lists. This should be easy to do. I'll send an updated patch when I'm back at a computer.
-- 
Sent from my Android. Please excuse my brevity.

Pieter Praet <pieter@praet.org> wrote:

Thanks Austin!

Unfortunately, your patch causes *all* Message-Id's in the thread to be
appended, as opposed to only the ones matching the query:

#+BEGIN_EXAMPLE
$ notmuch search tag:inbox AND from:amdragon@mit.edu
thread:0000000000002777 Yest. 19:17 [1/3] Austin Clements| Pieter Praet;
[PATCH 2/2] [RFC] possible solution for "Race condition for '*' command"
(inbox replied sent to-me x/notmuch)
id:"CAH-f9WticM4EN8F1_ik_-mcBcBtrXwSpO+Drbtp7=UN7McECrg@mail.gmail.com"
or id:"87zkkwydag.fsf@praet.org" or id:"20110703171743.GL15901@mit.edu"
#+END_EXAMPLE

As you can see, according to matched/total ("[1/3]") only a single
message matches the query, yet all 3 MsgId's are returned.

If this were to be corrected (probably a trivial change, but I'm pretty
much oblivious as to the what and where of it), the following patch
series should work as intended.

The "--stdin" option works as expected (and ARG_MAX is indeed a very
valid concern with this particular use case), but I haven't yet gotten
around to making use of it from the Emacs UI as this would require some
screwing around with `notmuch-tag' and `notmuch-call-notmuch-process',
and it's still pretty early I-).

Peace

-- 
Pieter


------TNBCPH3ADEBNTKTYUGJVLMN8JRAE0R
Content-Type: text/html;
 charset=utf-8
Content-Transfer-Encoding: 8bit

<html><head></head><body>Ah, this is subtler than I thought.  You&#39;re right that, for the &#39;*&#39; command, you want only the matched ID&#39;s.  Tagging a region, however, operates on entire threads.  I think it&#39;s important to retain this behavior because threads are what the user sees and selects in the search buffer (*, on the other hand, doesn&#39;t have a strong visual analogue).<br>
<br>
(This also means * is not, in fact, equivalent to expanding the region the the entire buffer and then tagging the region.)<br>
<br>
I should probably emit two lists per thread: one of matched IDs and one of unmatched IDs.  Tagging a region can then operate on the concatenation of these, while * can operate only on the matched lists.  This should be easy to do.  I&#39;ll send an updated patch when I&#39;m back at a computer.<br>
-- <br>
Sent from my Android. Please excuse my brevity.<br><br><div class="gmail_quote">Pieter Praet &lt;pieter@praet.org&gt; wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre style="white-space: pre-wrap; word-wrap:break-word; font-family: sans-serif">Thanks Austin!<br /><br />Unfortunately, your patch causes *all* Message-Id's in the thread to be<br />appended, as opposed to only the ones matching the query:<br /><br />#+BEGIN_EXAMPLE<br />$ notmuch search tag:inbox AND from:amdragon@mit.edu<br />thread:0000000000002777 Yest. 19:17 [1/3] Austin Clements| Pieter Praet;<br />[PATCH 2/2] [RFC] possible solution for "Race condition for '*' command"<br />(inbox replied sent to-me x/notmuch)<br />id:"CAH-f9WticM4EN8F1_ik_-mcBcBtrXwSpO+Drbtp7=UN7McECrg@mail.gmail.com"<br />or id:"87zkkwydag.fsf@praet.org" or id:"20110703171743.GL15901@mit.edu"<br />#+END_EXAMPLE<br /><br />As you can see, according to matched/total ("[1/3]") only a single<br />message matches the query, yet all 3 MsgId's are returned.<br /><br />If this were to be corrected (probably a trivial change, but I'm pretty<br />much oblivious as to the what and where of it), the following
patch<br />series should work as intended.<br /><br />The "--stdin" option works as expected (and ARG_MAX is indeed a very<br />valid concern with this particular use case), but I haven't yet gotten<br />around to making use of it from the Emacs UI as this would require some<br />screwing around with `notmuch-tag' and `notmuch-call-notmuch-process',<br />and it's still pretty early I-).<br /><br />Peace<br /><br />-- <br />Pieter<br /><br /></pre></blockquote></div></body></html>
------TNBCPH3ADEBNTKTYUGJVLMN8JRAE0R--