From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
 notmuch@notmuchmail.org
Subject: Re: [PATCH 0/9] test: (hopefully) better test prerequisites
In-Reply-To: <874ny36rhc.fsf@servo.finestructure.net>
References: <1321494986-18998-1-git-send-email-dmitry.kurochkin@gmail.com>
	<874ny36rhc.fsf@servo.finestructure.net>
User-Agent: Notmuch/0.10_rc1+9~g8270095 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Thu, 17 Nov 2011 15:20:07 +0400
Message-ID: <87hb23nggo.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

Hi Jameson.

On Thu, 17 Nov 2011 01:14:07 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> On Thu, 17 Nov 2011 05:56:17 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > The following patch series is an attempt to introduce proper
> > dependencies for external binaries in a less intrusive way than
> > [1].  The primary aim was to avoid changing every subtest that
> > uses external binaries.
> 
> Hey, Dmitry.  Thanks so much for reworking Pieter's original test suite
> improvements.  I think this new approach is a bit less invasive and a
> little more elegant to work with.
> 
> I've looked through the patchs, and they all look ok on first glance
> (barring any possibly needed modifications that I'm not seeing).  I have
> a couple of comments to follow.
> 
> However, when I tried to test the tests with the patch applied I ran
> into one problem.  If I try to run the test suite with dtach
> uninstalled, it looks like I'm experiencing a hang on
> emacs_deliver_message call.  I wonder if either emacs_deliver_message or
> test_emacs is not doing the right thing in the case of no dtach.  I
> think emacs_deliver_message should somehow not require dtach, since it's
> not actually testing any display stuff, but because it's currently using
> test_emacs, it is somehow implicitly depending on it.  Any thoughts on
> how to fix that?
> 

I bet you stumbled upon a hanging smtp-dummy.  There is a patch [1] to
fix that.  Hopefully it would get pushed soon.

As for not requiring dtach for emacs_deliver_message, that is definitely
possible.  Currently, there is only one way to run emacs to keep it
simple.  And I am not sure if running emacs_deliver_message without
dtach costs extra code.

Regards,
  Dmitry

[1] id:"yf639dnsqtc.fsf@taco2.nixu.fi"

> jamie.