MIME-Version: 1.0
Sender: awg@xvx.ca
In-Reply-To: <874ns15fky.fsf@steelpick.2x.cz>
References: <87ehr55knx.fsf@steelpick.2x.cz>
	<CAMoJFUsCe+U_j=oH0c=P6YmD2g_Jk8sxxtJ00JA_sM3dM5pOHQ@mail.gmail.com>
	<874ns15fky.fsf@steelpick.2x.cz>
Date: Mon, 30 Apr 2012 21:36:28 -0600
Message-ID:
 <CAMoJFUsnxbRz3yPZSVA0w8C2-Qt8fXx3X6i3RZ+QvZGv2EtiFQ@mail.gmail.com>
Subject: Re: JSON readtable error when replying
From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
To: Michal Sojka <sojkam1@fel.cvut.cz>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: notmuch <notmuch@notmuchmail.org>
Precedence: list

On Mon, Apr 30, 2012 at 10:50, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> json_xs didn't complain, but I've found that notmuch outputs
> =A0Failed to verify signed part: Cannot verify multipart/signed part: uns=
upported signature protocol 'application/x-pkcs7-signature'.
> to stderr before the json output and emacs tries to parse
> stderr. Emacs then complains about not finding "F" in json-readtable.
>
> The following patch fixes the problem for me, but I do not know if it is
> a good thing to throw away the stderr output of notmuch.
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index 87bd88d..49db603 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -113,7 +113,7 @@ list."
>
> =A0 =A0 ;; Get the reply object as JSON, and parse it into an elisp objec=
t.
> =A0 =A0 (with-temp-buffer
> - =A0 =A0 =A0(apply 'call-process (append (list notmuch-command nil (list=
 t t) nil) args))
> + =A0 =A0 =A0(apply 'call-process (append (list notmuch-command nil (list=
 t nil) nil) args))
> =A0 =A0 =A0 (goto-char (point-min))
> =A0 =A0 =A0 (let ((json-object-type 'plist)
> =A0 =A0 =A0 =A0 =A0 =A0(json-array-type 'list)
>
> Comments?

Good catch. I'm not sure what (if anything) we want to do with the
stderr output, but putting it in the buffer with the JSON is
definitely not the right thing. Your fix looks fine to me - would you
mind doing a commit and sending a patch to the list?

David, it would probably be good to get this (pretty trivial) fix in
before 0.13, since it will include the JSON reply stuff.

-- Adam