Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C742F431FBC for ; Mon, 20 May 2013 08:45:56 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FZiuxsSOfsIN for ; Mon, 20 May 2013 08:45:49 -0700 (PDT) Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 257FB431FB6 for ; Mon, 20 May 2013 08:45:49 -0700 (PDT) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r4KFjl4H008228; Mon, 20 May 2013 12:45:47 -0300 Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.82.78] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1UeSHT-0007T2-CW; Mon, 20 May 2013 12:45:47 -0300 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1UeSHN-0007hv-HX; Mon, 20 May 2013 12:45:41 -0300 From: David Bremner To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: Avoid deprecated function flet In-Reply-To: <1368976447-5153-1-git-send-email-amdragon@mit.edu> References: <87vc6fjjdp.fsf@zancas.localnet> <1368976447-5153-1-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.15.2+105~ge63aa66 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Mon, 20 May 2013 12:45:41 -0300 Message-ID: <8761ydr6xm.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 May 2013 15:45:57 -0000 Austin Clements writes: > flet was deprecated in Emacs 24.3 and replaced with cl-flet. However, > cl-flet lexically binds the function symbol, while we depend on flet > dynamically binding the function symbol. Hence, this patch replaces > the deprecated flet use with letf, which lets us dynamically bind the > function symbol, while remaining compatible with both Emacs 23 and 24. The bad news: letf is also marked as obsolete, although there is no yelling from the byte-compiler yet. In my simple tests, it _seemed_ to work to replace letf with cl-letf, although - that would require some kind of compatability alias - the docstring for letf mutters something about "deprecated usage of `symbol-function' in place forms. On the third hand, http://www.gnu.org/software/emacs/manual/html_node/elisp/Setting-Generalized-Variables.html#Setting-Generalized-Variables suggests using symbol-function with setf is legitimate.