From: Pieter Praet <pieter@praet.org>
To: servilio <servilio@gmail.com>
Subject: Re: [PATCH] emacs: Use a single buffer invisibility spec to fix
	quadratic search cost.
In-Reply-To:
 <CAPFwwQg3SHHoKuZ6=AfKOuVXm6L9p4aH1gEvqgkcXM8hQLaD7A@mail.gmail.com>
References: <1320807328-13728-1-git-send-email-amdragon@mit.edu>
	<877h382jax.fsf@SSpaeth.de>
	<CAPFwwQgsqe2NE9vm2RJHHK+8hWR_uMWKLHcxm0xkjduFboAfPw@mail.gmail.com>
	<87d3czxsu9.fsf@praet.org> <20111111045341.GS2658@mit.edu>
	<20111111052716.GU2658@mit.edu> <87d3ctjpsd.fsf@praet.org>
	<CAPFwwQg3SHHoKuZ6=AfKOuVXm6L9p4aH1gEvqgkcXM8hQLaD7A@mail.gmail.com>
User-Agent: Notmuch/0.9+76~g2fd88e6 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
Date: Wed, 16 Nov 2011 22:29:03 +0100
Message-ID: <87fwhndae8.fsf@praet.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
Precedence: list

On Tue, 15 Nov 2011 12:17:59 -0500, servilio <servilio@gmail.com> wrote:
> Hi,
> 
> Given that this change is about display of search results, I have the
> suspicion that the following two factors might be more relevant:
> 
> - size of the Emacs frame: bigger would mean more threads to show
> 
> - composition of the search results, specially length of the threads
> displayed, as the longer they go, the more hidden text there will be
> 
> And because of this, though you might already have a proper method for
> measuring it, the results are different. I thought about this because
> my searches have only ~180 threads, yet I could notice the difference.
> 

Definitely valid points, but these aren't likely to have affected my
test results, as every iteration started a fresh instance of Emacs,
full-screen, on the same screen, with the same query on the same
dataset, whilst ensuring -to a feasible degree- that Emacs was the
only thing vying for CPU time.

After including `redisplay' in the script (as suggested by Austin [1]),
I did get consistent results as well as a measurable performance
improvement due to the buffer invisibility spec patch.


As for the tests using `elp-instrument-package' and Austin's
`time-it' macro: I'm most likely just doing it wrong :)

> Servilio


Peace

-- 
Pieter

[1] id:"20111111052716.GU2658@mit.edu"