Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 39253431FC0; Fri, 27 Nov 2009 17:30:11 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tozKHzsMbzzE; Fri, 27 Nov 2009 17:30:10 -0800 (PST) Received: from cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 80C72431FAE; Fri, 27 Nov 2009 17:30:10 -0800 (PST) From: Carl Worth To: "Aneesh Kumar K.V" , notmuch@notmuchmail.org In-Reply-To: <1259125104-18785-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> References: <1259125104-18785-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Date: Fri, 27 Nov 2009 17:29:56 -0800 Message-ID: <874oofl9m3.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [notmuch] [PATCH] notmuch-new: Fix notmuch new to look at files within symbolic links X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Nov 2009 01:30:11 -0000 On Wed, 25 Nov 2009 10:28:24 +0530, "Aneesh Kumar K.V" wrote: > We look at the modified time of the database and the directory > to decide whether we need to look at only the subdirectories. > ie, if directory modified time is < database modified time > then we have already looking at all the files withing the > directory. So we just need to iterate through the subdirectories > > But with symlinks we need to make sure we follow them even if > the directory modified time is less than database modified time Thanks, Aneesh! I'm sure everyone with symlinks in their mail store is really going to appreciate this fix. This is now pushed out. -Carl