Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B2E6D429E26 for ; Tue, 24 Jan 2012 16:49:31 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tzM6Gof98CHz for ; Tue, 24 Jan 2012 16:49:31 -0800 (PST) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id DC460431FB6 for ; Tue, 24 Jan 2012 16:49:30 -0800 (PST) Received: by wgbdt12 with SMTP id dt12so4293418wgb.2 for ; Tue, 24 Jan 2012 16:49:29 -0800 (PST) Received: by 10.180.102.169 with SMTP id fp9mr24604163wib.9.1327452569691; Tue, 24 Jan 2012 16:49:29 -0800 (PST) Received: from localhost ([109.131.95.182]) by mx.google.com with ESMTPS id j16sm19762305wie.4.2012.01.24.16.49.28 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 Jan 2012 16:49:28 -0800 (PST) From: Pieter Praet To: Xavier Maillard , Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [PATCH 10/10] test: use emacsclient(1) for Emacs tests In-Reply-To: References: <1309236311-2162-1-git-send-email-dmitry.kurochkin@gmail.com> <1309236311-2162-10-git-send-email-dmitry.kurochkin@gmail.com> User-Agent: Notmuch/0.11+113~g5a6e67e (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Wed, 25 Jan 2012 01:47:33 +0100 Message-ID: <8739b4sj4p.fsf@praet.org> MIME-Version: 1.0 X-Gm-Message-State: ALoCoQmFlcq8jzoS9hUqUFNGx4cJmC9dbKU10/yWPH3pelMCn3qXZZ9Qfs44uJR7Lfk3yHSc8EVA Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jan 2012 00:49:31 -0000 On Mon, 23 Jan 2012 20:08:59 +0100, Xavier Maillard wrote: > On Tue, 28 Jun 2011 08:45:11 +0400, Dmitry Kurochkin wrote: > > Before the change, every Emacs test ran in a separate Emacs > > instance. Starting Emacs many times wastes considerable time and > > it gets worse as the test suite grows. The patch solves this by > > using a single Emacs server and emacsclient(1) to run multiple > > tests. Emacs server is started on the first test_emacs call and > > stopped when test_done is called. We take care not to leave > > orphan Emacs processes behind when test is terminated by whatever > > reason: Emacs server runs a watchdog that periodically checks > > that the test is still running. > > > > Some tests need to provide user input. Before the change, this > > was done using echo(1) to Emacs stdin. This no longer works and > > instead `standard-input' variable is set accordingly to make > > `read' return the appropriate string. > > I really like this too. > > +1 > Actually, these have all been pushed already, around June 2011. See commits e4fc21e8..a854d06e. I necrobumped this thread to keep my typo fix [1] in proper context. Which leaves me to ponder: should these kinds of fixes be sent in reply to the original patch (and potentially cause confusion), or would it be better to just start a new thread? > /Xavier > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch Peace -- Pieter [1] id:"1327292770-9528-1-git-send-email-pieter@praet.org"