From: Carl Worth <cworth@cworth.org>
To: Dirk Hohndel <hohndel@infradead.org>, notmuch@notmuchmail.org
In-Reply-To: <87y6l92yuw.fsf@yoom.home.cworth.org>
References: <1260511813.3341.22.camel@dhohndel-mobl.amr.corp.intel.com>
	<874onx4gyl.fsf@yoom.home.cworth.org>
	<87y6l92yuw.fsf@yoom.home.cworth.org>
Date: Fri, 11 Dec 2009 16:02:06 -0800
Message-ID: <87r5r12h6p.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Subject: Re: [notmuch] emacs mode performance issue
Precedence: list

--=-=-=

On Fri, 11 Dec 2009 09:40:23 -0800, Carl Worth <cworth@cworth.org> wrote:
> Which should let you tar these up and you can send them to me privately
> and I'll try to replicate and fix the bug.

Thanks for passing on the messages, Dirk. If anyone's curious the
message that triggered the bug is a public mail on the Linux Kernel
Mailing List:

	id:alpine.LFD.2.00.0912081304070.3560@localhost.localdomain

(It does have to be viewed in thread context---indented at least 13
columns to trigger the bug.)

The bug was an infinite loop add the button for a hidden citation,
(where our emacs lisp code got a bit confused about where the next line
was and infinitely looped on the same citation adding a never ending
sequence of "[1-line citation]" buttons).

I fixed the infinite loop and while in the area made a few other minor
improvements to the citation-hiding code:

  * No longer consider '>' as introducing a citation if not in first
    column.

  * No longer insert an the extra blank line after the citation button.

  * Add text to the citation button to tell new users that they can
    click or press Enter on the button to show the citation.

I'd still like to add one more feature which is a keybinding to make all
the citations for the current message visible. (It could even do the
whole thread like the button we used to have, but *only* if it ensured
that the current position of point within the current buffer and the
current window remained unchanged.)

I hope that's helpful,

-Carl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLIt1/6JDdNq8qSWgRAj93AKCRoyVUbcAfpEHEE1zuVZzxJCqnEwCfSa1d
vVX1WZmd1aAS99L/Nh/+FP0=
=GYah
-----END PGP SIGNATURE-----
--=-=-=--