Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D4566429E49 for ; Sun, 29 Jan 2012 14:29:40 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.098 X-Spam-Level: X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4X3CV0k9g7nb for ; Sun, 29 Jan 2012 14:29:40 -0800 (PST) Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 3126E429E48 for ; Sun, 29 Jan 2012 14:29:40 -0800 (PST) Received: from smtp.qmul.ac.uk ([138.37.6.40]) by mail2.qmul.ac.uk with esmtp (Exim 4.71) (envelope-from ) id 1RrdFi-0001K7-Jj; Sun, 29 Jan 2012 22:29:38 +0000 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] helo=localhost) by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) (envelope-from ) id 1RrdFi-0006iR-DR; Sun, 29 Jan 2012 22:29:38 +0000 From: Mark Walters To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH 3/3] emacs: Allow the indentation of content to be toggled. In-Reply-To: <1327486729-18052-4-git-send-email-dme@dme.org> References: <1327486729-18052-1-git-send-email-dme@dme.org> <1327486729-18052-4-git-send-email-dme@dme.org> User-Agent: Notmuch/0.11+137~g98adc3d (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Sun, 29 Jan 2012 22:30:42 +0000 Message-ID: <87zkd62lbh.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Sender-Host-Address: 94.192.233.223 X-QM-SPAM-Info: Sender has good ham record. :) X-QM-Body-MD5: 09df1d3b8a91e081aa39ce239dbfdc03 (of first 20000 bytes) X-SpamAssassin-Score: -1.8 X-SpamAssassin-SpamBar: - X-SpamAssassin-Report: The QM spam filters have analysed this message to determine if it is spam. We require at least 5.0 points to mark a message as spam. This message scored -1.8 points. Summary of the scoring: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [138.37.6.40 listed in list.dnswl.org] * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (markwalters1009[at]gmail.com) * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay * domain * 0.5 AWL AWL: From: address is in the auto white-list X-QM-Scan-Virus: ClamAV says the message is clean X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jan 2012 22:29:41 -0000 On Wed, 25 Jan 2012 10:18:49 +0000, David Edmondson wrote: > Very deeply indented content is sometimes difficult to > read (particular for something like patches). Allow the indentation of > the content to be toggled with '<'. > > Indentation of the header lines is not affected, so it remains > possible to see the structure of the thread. I really like the feature and would definitely use it. However, I have a couple of niggles with the implementation. First, when toggled it seems to redisplay so it jumps back to the first matching message regardless of where you are in the thread (and closes messages you have opened). Secondly, it doesn't seem to interact correctly with notmuch-wash-wrap-long-lines (the lines wrap at the place they would have wrapped had the text been indented). [I haven't yet worked how out notmuch-wash-wrap-long-lines and visual line mode etc are intended to interact so maybe the second point is moot.] Best wishes Mark (Sorry for the resend: I sent from the wrong address again)