Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id DCD75431FD6 for ; Fri, 10 Oct 2014 22:13:00 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bDFg3ItGIvXu for ; Fri, 10 Oct 2014 22:12:56 -0700 (PDT) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 306F6431FD0 for ; Fri, 10 Oct 2014 22:12:56 -0700 (PDT) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1Xcoz9-0000Qj-6B; Sat, 11 Oct 2014 02:12:55 -0300 Received: (nullmailer pid 4717 invoked by uid 1000); Sat, 11 Oct 2014 05:12:41 -0000 From: David Bremner To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH v2 03/12] lib: Handle empty date value In-Reply-To: <1412637438-4821-4-git-send-email-aclements@csail.mit.edu> References: <1412637438-4821-1-git-send-email-aclements@csail.mit.edu> <1412637438-4821-4-git-send-email-aclements@csail.mit.edu> User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Sat, 11 Oct 2014 07:12:41 +0200 Message-ID: <8738avgpfa.fsf@maritornes.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Oct 2014 05:13:01 -0000 Austin Clements writes: > From: Austin Clements > > In the interest of robustness, avoid undefined behavior of > sortable_unserialise if the date value is missing. This shouldn't > happen now, but ghost messages will have blank date values. Pushed the first 3 patches in the series. d