MIME-Version: 1.0
In-Reply-To: <876392ge3i.fsf@yoom.home.cworth.org>
References: <1258893156-25849-1-git-send-email-jan@ryngle.com>
	<876392ge3i.fsf@yoom.home.cworth.org>
Date: Mon, 23 Nov 2009 03:47:24 +0100
Message-ID: <f35dbb950911221847h6afa4bd4n9a634426613fed5d@mail.gmail.com>
From: Jan Janak <jan@ryngle.com>
To: Carl Worth <cworth@cworth.org>
Content-Type: text/plain; charset=UTF-8
Cc: notmuch@notmuchmail.org
Subject: Re: [notmuch] [PATCH] notmuch-new: Eliminate gcc warning caused by
	ino_cmp.
Precedence: list

On Mon, Nov 23, 2009 at 3:38 AM, Carl Worth <cworth@cworth.org> wrote:
> On Sun, 22 Nov 2009 13:32:36 +0100, Jan Janak <jan@ryngle.com> wrote:
>> The function passed to scandir in the fourth argument takes two
>> const void* arguments. To eliminate the gcc warning about incompatible
>> types, we change ino_cmp to match this and then re-type the parameters
>> in the body of ino_cmp.
>
> Actually, on my system at least, (Linux with glibc 2.10.1), our current
> function matches the prototype. So applying your patch actually
> *introduces* a warning where there was no warning before.
>
> What a nuisance...
>
> Any ideas for a good fix, anyone?

OK, I have an older version of glibc. If the original code works with
glibc 2.10 then just ignore the patch. I think testing for a
particular version of glibc is not worth the effort (it's just a
warning anyway).

  -- Jan