Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 0BB60429E33 for ; Thu, 5 Jan 2012 19:22:42 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PYNb8PTKslp6 for ; Thu, 5 Jan 2012 19:22:39 -0800 (PST) Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id BDB6E429E32 for ; Thu, 5 Jan 2012 19:22:39 -0800 (PST) Received: from zancas.localnet (fctnnbsc36w-156034072155.pppoe-dynamic.High-Speed.nb.bellaliant.net [156.34.72.155]) (authenticated bits=0) by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id q063MYDH031065 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Thu, 5 Jan 2012 23:22:37 -0400 Received: from bremner by zancas.localnet with local (Exim 4.77) (envelope-from ) id 1Rj0O2-0006h0-62; Thu, 05 Jan 2012 23:22:34 -0400 From: David Bremner To: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply" In-Reply-To: <974a2ef1f1df7d93e0b5bd642ca8a49f8b727a86.1325794371.git.jani@nikula.org> References: <974a2ef1f1df7d93e0b5bd642ca8a49f8b727a86.1325794371.git.jani@nikula.org> User-Agent: Notmuch/0.10.2+167~gadf1058 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Thu, 05 Jan 2012 23:22:34 -0400 Message-ID: <87boqhy0p1.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2012 03:22:42 -0000 On Thu, 5 Jan 2012 22:25:12 +0200, Jani Nikula wrote: > - notmuch_show_params_t params; > + notmuch_show_params_t params = { .part = -1 }; > > reply_format_func = notmuch_reply_format_default; > - params.part = -1; Do I understand correctly that this is just a style change, or do you rely on some c99(?) behaviour of initializing the other elements to 0? d