DomainKey-Signature: a=rsa-sha1; c=nofws; d=SSpaeth.de; h=from:to:cc:subject
	:in-reply-to:references:date:message-id:mime-version:
	content-type; q=dns; s=sspaeth.de; b=hfW058z5q/LWCdxRl6suRWtnQsb
	ha8MamNCTFOk1ZscagoX4S9wxr499647X8t8Nxzv+WRM1n619M5H+HGI7uDKt2Id
	ulSFSRvdVdHSl+86PMwvcR1Cfbn+8BaqH4WZklhei5e1XLRX6twSxXYwZotk5l4L
	2fRkHjH1/5b1wDc0=
From: Sebastian Spaeth <Sebastian@SSpaeth.de>
To: Patrick Totzke <patricktotzke@googlemail.com>,
	David Bremner <david@tethera.net>
Subject: Re: xapian exceptions not caught in python bindings?
In-Reply-To: <20110723133602.GA30241@brick.lan>
References: <20110626202733.GA26837@brick> <20110717193538.GA16615@brick.lan>
	<87r55o65yq.fsf@zancas.localnet> <20110723133602.GA30241@brick.lan>
User-Agent: Notmuch/0.5-233-gb404931 (http://notmuchmail.org) Emacs/23.2.1
	(x86_64-pc-linux-gnu)
Date: Tue, 09 Aug 2011 17:00:58 +0200
Message-ID: <87mxfipr2t.fsf@SSpaeth.de>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: Patrick Totzke <patricktotzke@googlemail.com>, notmuch@notmuchmail.org
Precedence: list

--=-=-=

On Sat, 23 Jul 2011 14:36:02 +0100, Patrick Totzke wrote:
> I hope the patch I send is correctly formated, I'm still fumbling with
> git send-email and the --in-reply-to option.
> Anyhow, forgive my language, of course I didn't mean to be condescending in any
> way by calling these prints garbage! It's just that it's highly unusual and very
> 'non-pythonic' that a module directly prints to stderr instead of raising exceptions
> and if you work directly with a curseslike interface on a terminal these
> errormessages litter my screen.

Hi,
1) I fixed the lack of throwing a NotmuchError when search_threads()
failed. This was a bug.

2) Taking over stderr and capturing it in a temporary file whenever we
create a query sounds incredibly hackish to me. It also potentially has
side-effects that I cannot even judge (we might be using stderr for
something completely different).

IMHO, libnotmuch should be modified to not directly print to stderr
but to provide a string with a detailed error message together with it's
status value. This would be the proper way to deal with it, even if it
means a bit more complexity in the notmuch binary.

Sebastian

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk5BS6oACgkQVYX1jMgnoGJSQgCfbZ4qjevLpwl79Ev4Lde1VHu+
kK8An3dmUJ1vLBUcVo8Dj5+BudHoaddP
=bEiy
-----END PGP SIGNATURE-----
--=-=-=--