Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id F2DC0431FBC
	for <notmuch@notmuchmail.org>; Wed,  7 Nov 2012 08:03:35 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 4YaXgfs435-p for <notmuch@notmuchmail.org>;
	Wed,  7 Nov 2012 08:03:35 -0800 (PST)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id 27F82431FAE
	for <notmuch@notmuchmail.org>; Wed,  7 Nov 2012 08:03:35 -0800 (PST)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id 0DC60100094
	for <notmuch@notmuchmail.org>; Wed,  7 Nov 2012 18:03:36 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH 1/1] notmuch-show.el: extended icalendar unfolding with
	single CR removal
In-Reply-To: <1349333712-18347-1-git-send-email-tomi.ollila@iki.fi>
References: <1349333712-18347-1-git-send-email-tomi.ollila@iki.fi>
User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Wed, 07 Nov 2012 18:03:36 +0200
Message-ID: <m2k3txpfhj.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Nov 2012 16:03:36 -0000

On Thu, Oct 04 2012, Tomi Ollila wrote:

> In case text/calendar content contained "folded" data (i.e. line
> continues to next line which begins with whitespace...
>
> or
>
> The text/calendar content is inside separate (application/octet-stream)
> content and the text/calendar entry there contains carriage returns...
>
> ... The parsing of text/calendar content failed so badly that in
> addition to just not showing the calendar content the rest of content
> handling of the thread aborted.
>
> In this change the input calendar content is unfolded extending the
> unfolding code used in `icalendar--get-unfolded-buffer` with single CRs
> removal.
> ---

I wrote comments on this patch but apparently I did not save my buffer
before git-send-email'ing it -- so here are the comments:


This obsoletes id:1349333712-18347-1-git-send-email-tomi.ollila@iki.fi
Commit message is changed to reflect change in pushed patch 
id:1350826509-12119-1-git-send-email-tomi.ollila@iki.fi
also, '\\r?' part in regexp was removed.

Note the difference how id:87d31artti.fsf@inf-8657.int-evry.fr
is inserted before and after this change.


Tomi