Return-Path: <bremner@pivot.cs.unb.ca>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 61BCB4196F4
	for <notmuch@notmuchmail.org>; Sat,  3 Apr 2010 14:22:05 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5
	tests=[BAYES_00=-1.9] autolearn=unavailable
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id FR-8HeeSfHlh for <notmuch@notmuchmail.org>;
	Sat,  3 Apr 2010 14:22:05 -0700 (PDT)
Received: from pivot.cs.unb.ca (pivot.cs.unb.ca [131.202.240.57])
	by olra.theworths.org (Postfix) with ESMTP id 091A34196F2
	for <notmuch@notmuchmail.org>; Sat,  3 Apr 2010 14:22:05 -0700 (PDT)
Received: from
	fctnnbsc30w-142167190087.pppoe-dynamic.high-speed.nb.bellaliant.net
	([142.167.190.87] helo=rocinante.cs.unb.ca)
	by pivot.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.69) (envelope-from <bremner@pivot.cs.unb.ca>)
	id 1NyAn5-0002GY-3l; Sat, 03 Apr 2010 18:22:03 -0300
Received: from bremner by rocinante.cs.unb.ca with local (Exim 4.71)
	(envelope-from <bremner@rocinante.cs.unb.ca>)
	id 1NyAmz-0007BP-A6; Sat, 03 Apr 2010 18:21:57 -0300
From: David Bremner <bremner@unb.ca>
To: Carl Worth <cworth@cworth.org>, David Edmondson <dme@dme.org>, notmuch
	<notmuch@notmuchmail.org>
In-Reply-To: <87tyrsz5rp.fsf@yoom.home.cworth.org>
References: <87oci344n4.fsf@ut.hh.sledj.net>
	<87bpe2j2vu.fsf@yoom.home.cworth.org> <87oci2xmkv.fsf@ut.hh.sledj.net>
	<87d3yhihzl.fsf@yoom.home.cworth.org> <87k4spxcz7.fsf@ut.hh.sledj.net>
	<87tyrsz5rp.fsf@yoom.home.cworth.org>
Date: Sat, 03 Apr 2010 18:21:57 -0300
Message-ID: <87pr2gs03u.fsf@rocinante.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Sender-Verified: bremner@pivot.cs.unb.ca
Subject: Re: [notmuch] pull request [was Re:  pull request]
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Apr 2010 21:22:05 -0000

On Sat, 03 Apr 2010 12:37:46 -0700, Carl Worth <cworth@cworth.org> wrote:
> 
> If I apply this patch as is, then when compiling the notmuch-show.el I
> get the following warnings:
> 
>   In notmuch-show:
>   notmuch-show.el:969:34:Warning: reference to free variable `notmuch-command'
> 
>   In end of data:
>   notmuch-show.el:983:1:Warning: the following functions are not known to be
>       defined: point-invisible-p, mail-header-extract-no-properties,
>       notmuch-select-tag-with-completion, union, intersection, set-difference,
>       notmuch-search-show-thread, mm-display-parts, mm-dissect-buffer,
>       notmuch-save-attachments, notmuch-count-attachments, notmuch-reply,
>       mm-handle-type, mm-display-part, notmuch-fontify-headers
> 

This is my understanding from staring at the code for a few other
packages; any experts feel free to contradict.

The warnings about unknown functions can be eliminated by use the
declare-function macro; if you have emacs lisp reference manual (it
required the package emacs23-common-non-dfsg on Debian) then you can
run:

ESC ESC : (info "(elisp)Declaring Functions") <RETURN>

For variables, the obvious approach is to make a file 'notmuch-vars.el'
and put the variables we need in several files there.