From: David Bremner <david@tethera.net>
To: Jameson Graef Rollins <jrollins@finestructure.net>, Daniel Kahn Gillmor
	<dkg@fifthhorseman.net>, notmuch <notmuch@notmuchmail.org>
Subject: Re: fix for failing tests with gmime 2.6.19
In-Reply-To: <87iovsxfu0.fsf@servo.finestructure.net>
References: <1384100482-15453-1-git-send-email-david@tethera.net>
	<52805350.70004@fifthhorseman.net> <87iovzywua.fsf@zancas.localnet>
	<87iovzvyui.fsf@zancas.localnet>
	<87iovsxfu0.fsf@servo.finestructure.net>
User-Agent: Notmuch/0.16+167~g9838fe8 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Sat, 16 Nov 2013 19:00:47 -0400
Message-ID: <878uwoymsg.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

Jameson Graef Rollins <jrollins@finestructure.net> writes:

> I agree with Daniel that the original series adds a whole lot of
> undesirable cruft to the test suite to get around one transient issue in
> one of the notmuch dependencies.  That doesn't seem like the best thing
> to do imho.  I would vote for this option instead, which doesn't modify
> the test suite and just skips the affected tests until the new gmime
> versions falls through everywhere.

FWIW, it does modify the test suite. The
patch-which-no-one-wrote-yet-but-probably-isn't-that-hard would have to
change the test suite to not treat skipped tests as errors.  I'm not
sure whether that's a harmless change or not. Missing prerequisites also
cause tests to be skipped, so in a sense this a change with more
repercussions.

d