Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 3701E6DE0350 for ; Tue, 29 Sep 2015 12:18:55 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 1.151 X-Spam-Level: * X-Spam-Status: No, score=1.151 tagged_above=-999 required=5 tests=[AWL=-0.245, SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3zxPTQFUb_0P for ; Tue, 29 Sep 2015 12:18:53 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by arlo.cworth.org (Postfix) with ESMTP id EAAA46DE025E for ; Tue, 29 Sep 2015 12:18:52 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 1E55C100080; Tue, 29 Sep 2015 22:18:57 +0300 (EEST) From: Tomi Ollila To: David Bremner , Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH v4 5/5] notmuch-emacs-mua: do not create a frame by default with --client In-Reply-To: <87wpva3j37.fsf@zancas.localnet> References: <455026447d3f75b1038ac11cebe734431604be9d.1439629384.git.jani@nikula.org> <87wpva3j37.fsf@zancas.localnet> User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2015 19:18:55 -0000 On Mon, Sep 28 2015, David Bremner wrote: > Tomi Ollila writes: > > >> if [ -n "$AUTO_DAEMON" -a -z "$CREATE_FRAME" ]; then >> echo "$0: --auto-daemon is only applicable with --create-frame." >&2 >> exit 1 >> fi >> >> without this one may execute ./notmuch-emacs-mua --client --auto-daemon >> which yields starting emacs in daemon mode (in this example it is expected >> emacs is not running; otherwise --auto-daemon has no use in this example) >> -- but no ui to that newly-running emacs is provided. Similar behaviour >> can be observed by the following >> > > I think what you propose is fine for a followup patch; note that the > scenario you worry about also needs --client to be a problem. Apparently > nothing is uncontroversial here, but if auto-daemon only works with > create frame, then perhaps the followup would be to have auto-daemon > imply create-frame Without --client --auto-daemon is no-op (as it is no-op in case emacs server is already running). I am (only) concerned about user experience when one runs --client --auto-daemon and user gets nothing (i.e. emacs server is running in the background w/o any clients connected to it. We could make --auto-daemon imply --create-frame, but then ./notmuch-emacs-mua --auto-daemon (i.e. w/o --client) starts new mail compose window to separate frame (even though user did not request it w/ --create-frame) (actually I already did the 'imply' option (easy, one line in script, another in namual), just that testing it gave this thought... ... therefore I'd rather make ./notmuch-emacs-mua --auto-daemon spit an error and exit -- but I can be convinced otherwise :) Tomi