Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D1900431FC0 for ; Wed, 1 Jan 2014 07:58:25 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TDYeAqmK1h5h for ; Wed, 1 Jan 2014 07:58:19 -0800 (PST) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 52357431FAF for ; Wed, 1 Jan 2014 07:58:19 -0800 (PST) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1VyOBT-00029y-Ol; Wed, 01 Jan 2014 11:58:15 -0400 Received: (nullmailer pid 15508 invoked by uid 1000); Wed, 01 Jan 2014 15:58:11 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] test: delay watchdog checks in emacs. In-Reply-To: <1359501973-27671-2-git-send-email-david@tethera.net> References: <1359501973-27671-1-git-send-email-david@tethera.net> <1359501973-27671-2-git-send-email-david@tethera.net> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Wed, 01 Jan 2014 11:58:11 -0400 Message-ID: <87a9ffofsc.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jan 2014 15:58:26 -0000 david@tethera.net writes: > From: David Bremner > > Instead of checking immediately for the watched process, delay a > minute, or in the case that process-attributes returns nil, for two > minutes. This is intended to cope with the case that > process-attributes is unimplimented, and returns always returns nil. > In this case, the watchdog check is the same as the two minute limit > imposed by timeout. > --- It seems there are still lingering problems with this. On a Debian Hurd system, the following consistently dies after running for two minutes. It seems like our test harness can't cope with the emacs server dying as well as it ought to. I'm not sure what the right answer is. A crude workaround would be to increase the hardcoded timeout. Alternatively, maybe test_emacs should make some effort to restart the server if it is no longer running. #!/usr/bin/env bash test_description="emacs fcc" . ./test-lib.sh for ((count=1; count<=1000; count++)); do id=fub.$count subject=meh echo attempting $count emacs_fcc_message \ "$subject" \ 'This is a test message with inline attachment with a filename' \ "(mml-attach-file \"$TEST_DIRECTORY/README\" nil nil \"inline\") (message-goto-eoh) (insert \"Message-ID: <$id>\n\")" delivered=$(find $MAIL_DIR/sent -type f | wc -l) if [[ $delivered != $count ]]; then GIT_EXIT_OK=1 echo FATAL: $count attempted $delivered delivered exit 1; fi done test_done