Return-Path: <cworth@cworth.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 1533440D16A
	for <notmuch@notmuchmail.org>; Fri, 29 Oct 2010 16:58:56 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -2.89
X-Spam-Level: 
X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5
	tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]
	autolearn=ham
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id xF4NoJ8Xmytg; Fri, 29 Oct 2010 16:58:45 -0700 (PDT)
Received: from yoom.home.cworth.org (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 960AE40D155;
	Fri, 29 Oct 2010 16:58:45 -0700 (PDT)
Received: by yoom.home.cworth.org (Postfix, from userid 1000)
	id 36914254007; Fri, 29 Oct 2010 16:58:45 -0700 (PDT)
From: Carl Worth <cworth@cworth.org>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: rfc: improved MIME handling (multipart)
In-Reply-To: <87y6fsoxls.fsf@ut.hh.sledj.net>
References: <87y6fsoxls.fsf@ut.hh.sledj.net>
User-Agent: Notmuch/0.3.1 (http://notmuchmail.org) Emacs/23.2.1
	(i486-pc-linux-gnu)
Date: Fri, 29 Oct 2010 16:58:45 -0700
Message-ID: <87vd4kpn4a.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Oct 2010 23:58:56 -0000

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Mon, 10 May 2010 11:33:03 +0100, David Edmondson <dme@dme.org> wrote:
> A (third) attempt at improved MIME handling, specifically for multipart,
> is at:
>    http://github.com/dme/notmuch/tree/mp3
>    git://github.com/dme/notmuch.git (branch 'mp3')

Hi David,

I went to pull this, but I couldn't find satisfactory commit
messages. Things like "multipart: Fix part counting" aren't descriptive
enough for me. What was broken? How was it fixed?

A good test for a bug-fix commit message is "Could a reasonable person
(skilled in the art) read my commit message and confidently create a
test case for my fix?". If not, please add more detail.

As for the non-bug-fix stuff here, similarly I can't tell exactly what
the changes are. I can see from the commit messages that the part
handling is changing. But under what situations does it now behave
differently? If I wanted to stress this to see if it inadvertently
breaks things, how might I do so?

I'd like to have fairly good answers for questions like that from the
commit messages, rather than having to reverse-engineer the answers from
the patches themselves.

Please feel free to resubmit these with some updated commit messages.

Thanks!

=2DCarl

=2D-=20
carl.d.worth@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFMy1+16JDdNq8qSWgRAlw2AJ9s7jda/OFH3wqnPXZdX0OBIF2B8wCgnXhW
gpu4U5DIrmke/uxvcEWRuys=
=iEvD
-----END PGP SIGNATURE-----
--=-=-=--