Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 156A8429E21 for ; Mon, 7 Nov 2011 04:59:12 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YuUpSGqX7Vxj for ; Mon, 7 Nov 2011 04:59:07 -0800 (PST) Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id A9E7A431FB6 for ; Mon, 7 Nov 2011 04:59:07 -0800 (PST) Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id pA7CwsNx014225; Mon, 7 Nov 2011 14:58:54 +0200 From: Tomi Ollila To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] contrib/nmbug: new script for sharing tags with a given prefix. In-Reply-To: <1320627586-10068-1-git-send-email-david@tethera.net> References: <1319906707-10141-2-git-send-email-david@tethera.net> <1320627586-10068-1-git-send-email-david@tethera.net> User-Agent: Notmuch/0.9+23~g556c5fa (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Bremner X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2011 12:59:12 -0000 On Sun, 6 Nov 2011 20:59:46 -0400, David Bremner wrote: > From: David Bremner > > The main idea is consider the notmuch database as analogous to the > work-tree. A bare git repo is maintained in the users home directory, > with a tree of the form tags/$message-id/$tag > > Like notmuch and git, we have a set of subcommnds, mainly modelled on > git. > > The most important commands are > > commit xapian -> git > checkout git -> xapian > merge fetched git + git -> xapian > status find differences between xapian, git, and remote git. > > There are also some convenience wrappers around git commands. > > In order to encode tags (viewed as octet sequences) into filenames, > we whitelist a smallish set of characters and %hex escape anything outside. > > The prefix is omitted in git, which lets one save and restore to > different prefixes (although this is only lightly tested). > --- > > Many things have changed, time for a repost. It no long needs the > "restore --match" patches. Good work. Could you do some simple things to help our reviewer's work: *) consistent spacing (around '='s and '{':s (and '=>':s) etc. *) consistent amount of newlines *) consitent quoting (use same ':s or ":s in similar context) *) M-x whitespace-cleanup (or M-x delete-trailing-whitespace) in pivot... *) something else than @ in m@ ... @x (at least in unpack_diff_lines) (confuses viewers) Tomi