From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>,
 Mark Walters <markwalters1009@gmail.com>,	notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: show: make id links respect window
In-Reply-To: <87bodgrh6a.fsf@zancas.localnet>
References: <1355958602-16752-1-git-send-email-markwalters1009@gmail.com>
	<87bodjfnt0.fsf@zancas.localnet> <87mwx2jsu0.fsf@qmul.ac.uk>
	<87bodgrh6a.fsf@zancas.localnet>
User-Agent: Notmuch/0.14+236~ge6d0259 (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-unknown-linux-gnu)
Date: Sat, 05 Jan 2013 23:50:43 +0200
Message-ID: <m2zk0ni9jg.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Wed, Dec 26 2012, David Bremner <david@tethera.net> wrote:

> Mark Walters <markwalters1009@gmail.com> writes:
>
>>> I can imagine that people would want/like the "open in other window" 
>>> effect of the current code, even if the reason is a bug.
>>
>> That's definitely possible. I generally expect a mouse click to select
>> the window I click and this feels counter intuitive. I think that some
>> people might like an option "open this link in a new window" but I would
>> guess that would like that whether they clicked or pressed RET on the
>> button.
>
> I don't care much either way myself, but before we change notmuch-show
> behaviour (effectively) to accomodate notmuch-pick, I'd like a bit more
> feedback from other people.

I tested the old behaviour -- split frame to 2 windows, one containing
*scratch* and one *notmuch-hello*. Then I searched for 'obsoletes',
chose last message (id:1356936162-2589-1-git-send-email-amdragon@mit.edu)
moved point to *scratch* buffer and clicked the id: link -- and indeed,
the *scratch* window was replaced.

I didn't look or test Mark's patch as he stated:
"The lisp is not pretty but seems to work." ;)
... well, not entirely because of that but I trust it opens the message
in window where the clicked link were and keeps point where it used to
be before clicking (in case point was in different window).

So, personally I'd like to see this fixed but I'm even less qualified
to comment the implementation in the patch.


> d

Tomi