Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B66BF431FB6 for ; Sat, 28 Jan 2012 00:09:09 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eclIcHbgbzzT for ; Sat, 28 Jan 2012 00:09:05 -0800 (PST) Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 5E6FC431FAE for ; Sat, 28 Jan 2012 00:09:05 -0800 (PST) Received: by werb10 with SMTP id b10so2216024wer.26 for ; Sat, 28 Jan 2012 00:09:04 -0800 (PST) Received: by 10.216.145.1 with SMTP id o1mr4314344wej.45.1327738143870; Sat, 28 Jan 2012 00:09:03 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id dr5sm31060867wib.0.2012.01.28.00.09.01 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 28 Jan 2012 00:09:02 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id 923929FF01; Sat, 28 Jan 2012 08:09:00 +0000 (GMT) To: Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [PATCH] test: remove ".sh" extension from the recently added Emacs tests In-Reply-To: <1327726059-17668-1-git-send-email-dmitry.kurochkin@gmail.com> References: <1327726059-17668-1-git-send-email-dmitry.kurochkin@gmail.com> User-Agent: Notmuch/0.11+122~g97bdcf6 (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Sat, 28 Jan 2012 08:08:55 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jan 2012 08:09:09 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 28 Jan 2012 08:47:39 +0400, Dmitry Kurochkin wrote: > All test files, except for the recently added Emacs tests, do not have > ".sh" extension. So remove it from the new test files for consistency. It's fine with me, though I'll point out that they have .sh because of id:"87k44r8s0a.fsf@gmail.com": > I like the idea of putting elisp testing code into .el files and calling > functions from regular tests (that is why I added test-lib.el). For > tests implemented in elisp, I propose adding a pair of files, e.g.: >=20 > tests/emacs-address.sh - tests that call elisp functions > tests/emacs-address.el - elisp code that actually implements the tests --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8jrRgACgkQaezQq/BJZRZUVwCfSm5IcZ7Zs5zT3y8EuYDco0ZY PA4An2imvVp2ERzXx/C8BG+pfNmxGBFQ =uhY+ -----END PGP SIGNATURE----- --=-=-=--