From: Pieter Praet <pieter@praet.org>
To: David Bremner <david@tethera.net>
Subject: Re: [PATCH] test: cli: getting/setting/removing config values
In-Reply-To: <87aa5qjx7l.fsf@zancas.localnet>
References: <8739bir7do.fsf@praet.org>
	<1326531476-14556-1-git-send-email-pieter@praet.org>
	<87aa5qjx7l.fsf@zancas.localnet>
User-Agent: Notmuch/0.11+78~g6c58370 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
Date: Mon, 16 Jan 2012 11:31:11 +0100
Message-ID: <874nvw2b2o.fsf@praet.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Precedence: list

On Sat, 14 Jan 2012 08:16:30 -0400, David Bremner <david@tethera.net> wrote:
> On Sat, 14 Jan 2012 09:57:56 +0100, Pieter Praet <pieter@praet.org> wrote:
> > Full test coverage for getting, setting and removing options in
> > notmuch(1)'s config file ($NOTMUCH_CONFIG or $HOME/.notmuch-config).
> > 
> > ---
> > +
> > +# FIXME: Not the most robust nor portable solution here...
> > +# Especially `hostname --domain' may have unwanted effects on
> > +# some platforms, e.g. setting your hostname to "--domain" ;)
> > +fallback_name="$(grep $(id -un) /etc/passwd | cut -d ":" -f 5 | cut -d "," -f 1)"
> > +fallback_email="$(id -un)@$(hostname).$(hostname --domain)"
> 
> I'm not sure how portable it is, but maybe dnsdomainname would at least
> have better failure modes.
> 

Hmmm, `dnsdomainname' returns "(none)" here;  Does it work for you?

Running `domainname' instead seems to do the right thing though...


It would probably be safest to simply mirror how it's done @
notmuch-config.c:313, but that seems rather excessive.

> I also wondered about using getent instead of grep.
> 

Agreed, much safer;  `grep' might return multiple results.

> d

How about this? :

  #+begin_src sh
    fallback_name="$(getent passwd ${USER} | cut -d ":" -f 5 | cut -d "," -f 1)"
    test -n "${EMAIL}" \
        && fallback_email="${EMAIL}" \
        || fallback_email="${USER}@$(hostname).$(domainname)"
  #+end_src


Peace

-- 
Pieter