Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 6C744421192 for ; Thu, 30 Jun 2011 19:23:56 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3H8aMQUm6IiS for ; Thu, 30 Jun 2011 19:23:56 -0700 (PDT) Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id BD20842118E for ; Thu, 30 Jun 2011 19:23:55 -0700 (PDT) Received: by bwg12 with SMTP id 12so2613032bwg.26 for ; Thu, 30 Jun 2011 19:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; bh=WxedHnerPB9kKg3PXqXEzJXjwTxEsWWWNjc9bmMi2cM=; b=tkNb0Uja2ckqm7d+tOu4WsPvqUHvIA68WkF2krj5cSDCMsQ/mSKnx+sXm4wW7F5EVJ zaINL0R23SZGAmRs5AnoalVAFDWR2d9waYs2VNdgA9Qx0iGWgYEeksbWs8PkR+6OIVQE RGdNb0rJkEXuVmRiX0w96BYKxW9iCs9+tWeAM= Received: by 10.205.35.1 with SMTP id su1mr2577091bkb.129.1309487034360; Thu, 30 Jun 2011 19:23:54 -0700 (PDT) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id k16sm2579058bks.1.2011.06.30.19.23.52 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 30 Jun 2011 19:23:53 -0700 (PDT) From: Dmitry Kurochkin To: notmuch@notmuchmail.org Subject: [PATCH] test: do not hide test_emacs errors Date: Fri, 1 Jul 2011 06:23:48 +0400 Message-Id: <1309487028-18786-1-git-send-email-dmitry.kurochkin@gmail.com> X-Mailer: git-send-email 1.7.5.4 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2011 02:23:56 -0000 Do not redirect test_emacs stderr to /dev/null. Test_emacs uses emacsclient(1) now and it does not print unwanted messages (like those from `message') to stderr. But it does print useful errors, e.g. when emacs server connection fails, given expression is not valid or undefined function is called. --- test/emacs | 4 ++-- test/test-lib.sh | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/emacs b/test/emacs index 53f455a..dbe8d9e 100755 --- a/test/emacs +++ b/test/emacs @@ -261,13 +261,13 @@ test_begin_subtest "Save attachment from within emacs using notmuch-show-save-at # save as archive to test that Emacs does not re-compress .gz test_emacs '(let ((standard-input "\"attachment1.gz\"")) (notmuch-show "id:cf0c4d610911171136h1713aa59w9cf9aa31f052ad0a@mail.gmail.com") - (notmuch-show-save-attachments))' > /dev/null 2>&1 + (notmuch-show-save-attachments))' test_expect_equal_file attachment1.gz "$EXPECTED/attachment" test_begin_subtest "Save attachment from within emacs using notmuch-show-save-part" # save as archive to test that Emacs does not re-compress .gz test_emacs '(let ((standard-input "\"attachment2.gz\"")) - (notmuch-show-save-part "id:cf0c4d610911171136h1713aa59w9cf9aa31f052ad0a@mail.gmail.com" 5))' > /dev/null 2>&1 + (notmuch-show-save-part "id:cf0c4d610911171136h1713aa59w9cf9aa31f052ad0a@mail.gmail.com" 5))' test_expect_equal_file attachment2.gz "$EXPECTED/attachment" test_begin_subtest "View raw message within emacs" diff --git a/test/test-lib.sh b/test/test-lib.sh index 22e387e..37f007a 100755 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -394,7 +394,7 @@ emacs_deliver_message () (message-goto-body) (insert \"${body}\") $@ - (message-send-and-exit))" >/dev/null 2>&1 + (message-send-and-exit))" wait ${smtp_dummy_pid} notmuch new >/dev/null } -- 1.7.5.4