From: Mark Walters <markwalters1009@gmail.com>
To: David Edmondson <dme@dme.org>, Aaron Ecay <aaronecay@gmail.com>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH v2] emacs: Add support for saved search accelerators
In-Reply-To: <cunwqdrbkd0.fsf@hotblack-desiato.hh.sledj.net>
References: <1399385776-19918-1-git-send-email-dme@dme.org>
	<1399461694-25350-1-git-send-email-dme@dme.org>
	<1399461694-25350-2-git-send-email-dme@dme.org>
	<87zjislji0.fsf@qmul.ac.uk> <87oaz5uzco.fsf@gmail.com>
	<cunwqdrbkd0.fsf@hotblack-desiato.hh.sledj.net>
User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Fri, 06 Jun 2014 14:12:28 +0100
Message-ID: <87y4xadvwj.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list

On Mon, 12 May 2014, David Edmondson <dme@dme.org> wrote:
> On Sat, May 10 2014, Aaron Ecay wrote:
>> 2014ko maiatzak 8an, Mark Walters-ek idatzi zuen:
>>>
>>> Hi
>>>
>>> This version looks good to me.
>>>
>>> The only slight query I have is which key to bind it to: Austin used g
>>> in notmuch-go and this uses j. Austin said on irc that he chose g
>>> because it wasn't bound and matched gmail's shortcut.
>>>
>>> Personally I like j (as it starts fewer words than g) and given that we
>>> don't match any of gmail's other bindings I don't think there is much
>>> advantage to doing so in this case.
>>
>> All other things being equal, I=E2=80=99d prefer =E2=80=9Cj=E2=80=9D her=
e, but for different
>> reasons.  =E2=80=9Cg=E2=80=9D is the emacs-standard key to refresh or re=
vert a buffer.
>> In my personal customization file I bound =E2=80=9Cg=E2=80=9D to
>> notmuch-refresh-this-buffer in notmuch-(show/search)-mode-map long ago
>> (and forgot this binding was not standard until reading above that g is
>> not bound).  It=E2=80=99s probably better emacs citizenship to not use s=
uch a
>> standard key for a different purpose.
>
> +1, though I won't lose sleep.

That sounds like a consensus so +1 from me.

Best wishes

Mark