Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id AF217431FD9 for ; Mon, 9 Feb 2015 23:06:29 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 2.438 X-Spam-Level: ** X-Spam-Status: No, score=2.438 tagged_above=-999 required=5 tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vkl9MUo6lKUo for ; Mon, 9 Feb 2015 23:06:26 -0800 (PST) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 31D78431FD2 for ; Mon, 9 Feb 2015 23:06:26 -0800 (PST) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id A0FC8100051; Tue, 10 Feb 2015 09:06:02 +0200 (EET) From: Tomi Ollila To: Nils Dagsson Moskopp , notmuch@notmuchmail.org Subject: Re: bug report: Emacs notmuch-mode fails attachments with spaces In-Reply-To: <87twyurc78.fsf@dieweltistgarnichtso.net> References: <87twyurc78.fsf@dieweltistgarnichtso.net> User-Agent: Notmuch/0.19+53~gb45d2f9 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2015 07:06:30 -0000 On Mon, Feb 09 2015, Nils Dagsson Moskopp w= rote: > Dear notmuch developers, > > > I use notmuch-mode for GNU Emacs for managing my email. > > I think I have found a bug in notmuch-mode: If I do =E2=80=9C.-v=E2=80=9D= on the line =E2=80=9C[ > 2015 _ Richtlinien.pdf: application/pdf ]=E2=80=9D, then notmuch will ope= n three > windows of zathura (the PDF viewer I use). > > It seems to me that someone here either forgot quoting or decided to > split filenames on spaces. I suggest that =E2=80=9C2015 _ Richtlinien.pdf: > application/pdf=E2=80=9D should be quoted in notmuch-show-view-part. > > Note that saving attachment (=E2=80=9C.-s=E2=80=9D, notmuch-show-save-par= t) generally > works even if the attachment file names have spaces. In case it matters, > I normally use the rc(1) shell in Debian . This code handles the saving and displaying in question (quick look hop i am right :) 2282 (defun notmuch-show-save-part () 2283 "Save the MIME part containing point to a file." 2284 (interactive) 2285 (notmuch-show-apply-to-current-part-handle #'mm-save-part)) 2286=20 2287 (defun notmuch-show-view-part () 2288 "View the MIME part containing point in an external viewer." 2289 (interactive) 2290 ;; Set mm-inlined-types to nil to force an external viewer 2291 (let ((mm-inlined-types nil)) 2292 (notmuch-show-apply-to-current-part-handle #'mm-display-part))) SO, there is 2 options: 1) mm executes save part correctly but not display part 2) there is (shell) wrapper program executing zathura which cannot handle arguments with spaces (there is plenty of examples of this!) You could try to check how th external processes are executed by executing: strace -f -e trace=3Dprocess emacs -f notmuch (emacs on X is preferable in this case ;) Tomi > > > Greetings, > --=20 > Nils Dagsson Moskopp // erlehmann > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch