Date: Fri, 31 Oct 2014 11:18:13 -0700
From: "W. Trevor King" <wking@tremily.us>
To: Jesse Rosenthal <jrosenthal@jhu.edu>
Subject: Re: [PATCH] test: Make gen-threads work with python3
Message-ID: <20141031181812.GS15443@odin.tremily.us>
References: <1414776805-30000-1-git-send-email-jrosenthal@jhu.edu>
	<20141031174153.GQ15443@odin.tremily.us> <87bnosdsjh.fsf@jhu.edu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="vdyjigDobekge4RG"
Content-Disposition: inline
In-Reply-To: <87bnosdsjh.fsf@jhu.edu>
OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;
	url=http://tremily.us/pubkey.txt
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: notmuch@notmuchmail.org
Precedence: list


--vdyjigDobekge4RG
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 31, 2014 at 02:04:50PM -0400, Jesse Rosenthal wrote:
> W. Trevor King writes:
> > On Fri, Oct 31, 2014 at 01:33:25PM -0400, Jesse Rosenthal wrote:
> >> We instead initalize the dictionary using the dict comprehension
> >> and then update it with the values from the tree. This will work
> >> with both python2 and python3.
> >
> > Dict comprehensions are new in 2.7 [1,2], so this drops support
> > for systems where =E2=80=98python=E2=80=99 means =E2=80=98python2.6=E2=
=80=99.  Personally, I'm
> > fine with that, but I thought I'd point it out in case 2.6 users
> > wanted to push back ;).
>=20
> The comprehension was already in the previous version, so I figured that
> people were already cool with 2.7+.

Ah, good point :).  Besides looking good to me, I can confirm that I
see a TypeError (and a lot of CPU usage ;) from T260-thread-order.sh
before this patch which is fixed by this patch.

Cheers,
Trevor

--=20
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

--vdyjigDobekge4RG
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJUU9JiAAoJEG8/JgBt8ol88CgP/3eB+Xr4T2KBCWgdCCHV3M/G
xhcpqPnXZGw8jVQLn4RVbthrg4Z0ZbbMrpMstdqPnh6+SPlqzXUdvverz6ILlcdL
MCWHDll3wiq6d9Fa2FkdQZMD3UUpYdEP/JzVM77VDQGB0EYytDs1jIHh6K1a00uE
UvdBlT87ik1yoHWIBbb/n56ZWcRq3wTMcveDBaPo0Z0nrxtT8kZM0RNX6ONuYvFF
8DZeREVeImjy/vgIltuXTTpZ7QdDrnuxYpv3JE08vOc2hLPtJNXhQJDypmGX7N55
JfumCL0cOjlQe18tChxnlfPj7X6QqVy0wvwG+8GtJhNPAmiVhATQDpM9AxCslk4a
d3LFEus1jrIysq5q86gRTmWJeGTz+XmJNqvod35cPKsWOR2WI4nvwVuqarktvFZi
2kvyCqVJ80gYCyGqhQ1VkpeNf8vk1g/+isrd9Ja928pfYnfSeVRz4t2PnlCuigZA
5HeKGQVTyEf6xamR9SrB2nfTMLUW9inXofEhpzX4n5uRTyPvf4ifxuqhLGBDtj+h
R01COJy1Jd7x2CBErqABjk+ygKWzZd5GKoCStzFVJeAQvwm7TSAcNyPZsE/x+sLw
m0Q9yCP56i4fQDTjbP4Xj0F3pnmamI0TDu31POk0LyxQmA4rK1XlHoOHxu8rNzcv
sgTX8zho6VJ3NVP6TzQJ
=WRqI
-----END PGP SIGNATURE-----

--vdyjigDobekge4RG--