Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 704B2431FB6 for ; Sat, 4 May 2013 07:10:49 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8eETCpxPBeGN for ; Sat, 4 May 2013 07:10:43 -0700 (PDT) Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 7256B431FAF for ; Sat, 4 May 2013 07:10:43 -0700 (PDT) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r44EAgSB004301; Sat, 4 May 2013 11:10:42 -0300 Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.82.78] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1UYdAg-0002k1-1O; Sat, 04 May 2013 11:10:42 -0300 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1UYdAa-0003Rc-Cv; Sat, 04 May 2013 11:10:36 -0300 From: David Bremner To: Aaron Ecay , notmuch@notmuchmail.org Subject: Re: [PATCH 2/2] lib/database.cc: change how the parent of a message is calculated In-Reply-To: <1362540709-28765-2-git-send-email-aaronecay@gmail.com> References: <87ppzfzxuk.fsf@zancas.localnet> <1362540709-28765-1-git-send-email-aaronecay@gmail.com> <1362540709-28765-2-git-send-email-aaronecay@gmail.com> User-Agent: Notmuch/0.15.2+84~g12d5e4e (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Sat, 04 May 2013 11:10:36 -0300 Message-ID: <87ppx6al9f.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 May 2013 14:10:49 -0000 Aaron Ecay writes: > + if (ref && strcmp(ref, message_id)) { > + return ref; > + } else { > + return NULL; > + } As a nit, there should be a space after strcmp. But if nobody has any other comments, I could amend that. d