Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C73E4431FB6 for ; Thu, 19 Apr 2012 07:33:38 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f7Uqy1Uu2Ewq for ; Thu, 19 Apr 2012 07:33:34 -0700 (PDT) Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 8E132431FAE for ; Thu, 19 Apr 2012 07:33:34 -0700 (PDT) Received: by lahc1 with SMTP id c1so6761461lah.26 for ; Thu, 19 Apr 2012 07:33:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:x-originating-ip:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=qukdwHJ7QLO+g+NHDIP8NxnVjcKM4ENaAgAgRkJS7v4=; b=OiW7Z4Jrw1atNI9i9+6rBLAMCeXYu6RA9Kk7T78uFX6yGdTcuvJwMJzOXnWgZvVtJZ QM6NUwUU5u47tqJ1pCmvNmbxFm+3l6pQVeDK3WL1BePkM5IOB1gjNUYEAW9hzK6KJoyo XGLvrSi9KIhd0BZKhwmrfi9ruSQb+jWmnXKYOAAcTQg/oSkQECmiYCHAe0+BeaiiomHk Xq93idskFcIkhLVDIFQfA4UcC2X9ZdL2UvqfMXMxQlTbwFHcj2wtmnXC9vvYVnX7AcsT fP8zgDdagCxbLp8U6qV/JA10MZBdBHjQR9/YKa4nD4V+/vwDDyNoaoWjYqLoQK4MICuz vZZg== MIME-Version: 1.0 Received: by 10.112.51.225 with SMTP id n1mr1146162lbo.27.1334846011541; Thu, 19 Apr 2012 07:33:31 -0700 (PDT) Sender: awg@xvx.ca Received: by 10.112.23.39 with HTTP; Thu, 19 Apr 2012 07:33:31 -0700 (PDT) X-Originating-IP: [96.52.216.56] In-Reply-To: <87bompjb4n.fsf@schoepe.localhost> References: <1329503684-31289-1-git-send-email-daniel@schoepe.org> <87bompjb4n.fsf@schoepe.localhost> Date: Thu, 19 Apr 2012 08:33:31 -0600 X-Google-Sender-Auth: j8lPE23lM5ma4z-6ZAR0EOUyLaw Message-ID: Subject: Re: [PATCH] emacs: Add configurable wrapping width for notmuch-wash-wrap-long-lines From: Adam Wolfe Gordon To: Daniel Schoepe Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQmvyQnw+DXZESlydZkhc8Za+pI5iBpJdVZn9e5LkbojcSxjhoVbzCGLswD6U/LXJ6YhEf4Y Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2012 14:33:38 -0000 On Wed, Apr 18, 2012 at 09:46, Daniel Schoepe wrote: > the reason for not making this a defcustom was that all of the other > functions in notmuch-wash.el use defvar for customization too, so > perhaps they should all be defcustom'd in a separate patch? Ah, yes, I see now. Most of those variables (the regexps and button-formats) probably don't need to be customizable - it seems unlikely that anyone will want to change them except for internationalization, which should probably be done differently anyway. I think it makes sense for the others to be customs, so doing that in a separate patch is a good idea. Thanks again for this patch - it makes my mail read reading much more pleasant. -- Adam