DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=sender:from:to:subject:in-reply-to:references:date:message-id
	:mime-version:content-type;
	b=EQ6cbB5Na96CYzz2IJ0d33fljw+lkZpP59xt3znGklOUyrVW88BQmrcdgni2UAQOo6
	dijFfo8HRasA3SaTr4uuz5onbs1cABLVBiZoymTPo5aYE8Oqe6cWgcV+julHW0DZALF0
	0h+QBNNQiRibk5wwEGgtr8hMc7vWZF/qOu+iU=
Sender: Pablo Oliveira <pablo.oliveira@gmail.com>
From: Pablo Oliveira <pablo@sifflez.org>
To: notmuch@notmuchmail.org
In-Reply-To: <87bphgodh7.fsf@sifflez.org>
References: <87bphgodh7.fsf@sifflez.org>
Date: Wed, 30 Dec 2009 13:47:45 +0100
Message-ID: <87aax0ocge.fsf@sifflez.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [notmuch] [PATCH] Goto-Address mode hides the body toggle
 button on messages of zero depth.
Precedence: list


Hello all,

I heard about notmuch some weeks ago and I'm already liking it
a lot. At first I was a little disapointed by the slow tagging, 
but that was fixed by Kan-Ru's great patch for Xapian. I have
started using it daily, so many thanks for this mail reader !

On Wed, 30 Dec 2009 13:25:40 +0100, Pablo Oliveira <pablo@sifflez.org> wrote:
> In this patch we increment depth by one for all messages, so that the 
> first character of the header is always a space. Without this patch, 
> the first character may be part of the sender email address, which is 
> buttonized by Goto-Address minor mode, therefore hiding the 
> notmuch-button-body-toggle-type button, and forcing us to do an 
> additional C-e to hit it.

One of the things I find counter-intuitive is that on closed messages
of zero depth, the toggle body button is hidden by the email address
button, so when working with the keyboard, it seems one cannot open
the message, without moving further on the header button.

I propose above fix because it is very simple, but I do not like that
we lose one level of indentation on all the threads (screen space
is precious). Another solution would be to change the name-email 
order in the header... Or maybe we should deactivate somehow, the
Goto-Address mode on headers ? What do you think ?

Regards,

Pablo.