MIME-Version: 1.0
Sender: polatel@gmail.com
In-Reply-To: <1335185032-13075-1-git-send-email-felipe.contreras@gmail.com>
References: <1335185032-13075-1-git-send-email-felipe.contreras@gmail.com>
Date: Mon, 23 Apr 2012 17:04:43 +0300
Message-ID:
 <CADv3eywAvyMuh3vWLwyuf0Ui_kskwp9875pGxCR1GTm7deN9Pg@mail.gmail.com>
Subject: Re: [PATCH] ruby: make sure the database is closed
From: Ali Polatel <alip@exherbo.org>
To: Felipe Contreras <felipe.contreras@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: notmuch@notmuchmail.org
Precedence: list

2012/4/23 Felipe Contreras <felipe.contreras@gmail.com>:
> If the Ruby code does not manually close the database, we need to make
> sure it's closed when garbage collected.
>
> In Ruby, users are not _required_ to close, the garbage collector should
> take care of that.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
> =A0bindings/ruby/database.c | =A0 =A08 +++++++-
> =A01 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/bindings/ruby/database.c b/bindings/ruby/database.c
> index 982fd59..7b2ed47 100644
> --- a/bindings/ruby/database.c
> +++ b/bindings/ruby/database.c
> @@ -20,10 +20,16 @@
>
> =A0#include "defs.h"
>
> +static void
> +database_free (void *p)
> +{
> + =A0 =A0notmuch_database_close (p);
> +}
> +
> =A0VALUE
> =A0notmuch_rb_database_alloc (VALUE klass)
> =A0{
> - =A0 =A0return Data_Wrap_Struct (klass, NULL, NULL, NULL);
> + =A0 =A0return Data_Wrap_Struct (klass, NULL, database_free, NULL);
> =A0}
>
> =A0/*
> --
> 1.7.10
>

I'd rather not do this.
Please read: http://comments.gmane.org/gmane.comp.lang.ruby.general/320324

        -alip