Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 324B8431FD7
	for <notmuch@notmuchmail.org>; Mon, 26 Aug 2013 11:36:12 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id BPUY-bZOL0Rx for <notmuch@notmuchmail.org>;
	Mon, 26 Aug 2013 11:36:07 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id 714CF431FAF
	for <notmuch@notmuchmail.org>; Mon, 26 Aug 2013 11:36:07 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id 432E3100030;
	Mon, 26 Aug 2013 21:36:01 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [Patch (rebased) 0/2] contrib: pick: remove an unused variable
In-Reply-To: <1377460214-4795-1-git-send-email-markwalters1009@gmail.com>
References: <1377460214-4795-1-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.16+36~g947c286 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Mon, 26 Aug 2013 21:36:01 +0300
Message-ID: <m2ob8ke1v2.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Aug 2013 18:36:12 -0000

On Sun, Aug 25 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> This is a rebased version of
> id:1372712861-13515-1-git-send-email-markwalters1009@gmail.com.
>  
> When documenting notmuch-pick-worker I realised that
> notmuch-pick-buffer-name was an essentially unused argument: it is
> only used to reset itself on refresh.
>
> (Possibly this was a mis-copy from notmuch-show or possibly a left
> over from refesh used kill-buffer instead of erase-buffer.)
>
> In any case we might as well remove it and then document the function.

LGTM.

Tomi

>
> Best wishes
>
> Mark
>
> Mark Walters (2):
>   contrib: pick: remove unneeded variable notmuch-pick-buffer-name
>   contrib: pick: add docstring for notmuch-pick-worker
>
>  contrib/notmuch-pick/notmuch-pick.el |   19 ++++++++-----------
>  1 files changed, 8 insertions(+), 11 deletions(-)
>
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch