Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 26249431FBC
	for <notmuch@notmuchmail.org>; Sat, 15 Dec 2012 06:34:38 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id JUGnbZSmTA4N for <notmuch@notmuchmail.org>;
	Sat, 15 Dec 2012 06:34:37 -0800 (PST)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id E626F431FB6
	for <notmuch@notmuchmail.org>; Sat, 15 Dec 2012 06:34:36 -0800 (PST)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id CE39410007E;
	Sat, 15 Dec 2012 16:34:31 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] contrib: pick: archive message updated
In-Reply-To: <1354970494-18050-1-git-send-email-markwalters1009@gmail.com>
References: <1354970494-18050-1-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.14+116~g29fcdb5 (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sat, 15 Dec 2012 16:34:31 +0200
Message-ID: <m2txrnpeo8.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Dec 2012 14:34:39 -0000

On Sat, Dec 08 2012, Mark Walters <markwalters1009@gmail.com> wrote:

> Update pick's archive message to respect notmuch-archive-tags. Also
> split archive message into an archiving part and a separate
> "then-next" part, to move more inline with show. Update the keybinding
> so default behaviour is unchanged.
> ---

LGTM.

Tomi


>
> Notmuch pick had fallen behind show so update.
>
> Best wishes 
>
> Mark
>
>
>  contrib/notmuch-pick/notmuch-pick.el |   21 +++++++++++++++++----
>  1 files changed, 17 insertions(+), 4 deletions(-)
>
> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
> index 755cbbc..36587a6 100644
> --- a/contrib/notmuch-pick/notmuch-pick.el
> +++ b/contrib/notmuch-pick/notmuch-pick.el
> @@ -173,7 +173,7 @@
>      (define-key map "q" 'notmuch-pick-quit)
>      (define-key map "x" 'notmuch-pick-quit)
>      (define-key map "?" 'notmuch-help)
> -    (define-key map "a" 'notmuch-pick-archive-message)
> +    (define-key map "a" 'notmuch-pick-archive-message-then-next)
>      (define-key map "=" 'notmuch-pick-refresh-view)
>      (define-key map "s" 'notmuch-search)
>      (define-key map "z" 'notmuch-pick)
> @@ -393,10 +393,23 @@ Does NOT change the database."
>        (kill-buffer notmuch-pick-message-buffer))
>      t))
>  
> -(defun notmuch-pick-archive-message ()
> +(defun notmuch-pick-archive-message (&optional unarchive)
> +  "Archive the current message.
> +
> +Archive the current message by applying the tag changes in
> +`notmuch-archive-tags' to it (remove the \"inbox\" tag by
> +default). If a prefix argument is given, the message will be
> +\"unarchived\", i.e. the tag changes in `notmuch-archive-tags'
> +will be reversed."
> +  (interactive "P")
> +  (when notmuch-archive-tags
> +    (apply 'notmuch-pick-tag
> +	   (notmuch-tag-change-list notmuch-archive-tags unarchive))))
> +
> +(defun notmuch-pick-archive-message-then-next (&optional unarchive)
>    "Archive the current message and move to next matching message."
> -  (interactive)
> -  (notmuch-pick-tag "-inbox")
> +  (interactive "P")
> +  (notmuch-pick-archive-message unarchive)
>    (notmuch-pick-next-matching-message))
>  
>  (defun notmuch-pick-next-message ()
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch