Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 594CC429E35 for ; Sun, 4 Dec 2011 11:31:57 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oY2AxG2LddGf for ; Sun, 4 Dec 2011 11:31:56 -0800 (PST) Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU [18.9.25.12]) by olra.theworths.org (Postfix) with ESMTP id CCE91429E26 for ; Sun, 4 Dec 2011 11:31:53 -0800 (PST) X-AuditID: 1209190c-b7f806d0000008d6-59-4edbcaa97985 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP id 47.BE.02262.9AACBDE4; Sun, 4 Dec 2011 14:31:53 -0500 (EST) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id pB4JVrd7006821; Sun, 4 Dec 2011 14:31:53 -0500 Received: from drake.mit.edu (209-6-116-242.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com [209.6.116.242]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id pB4JVp2N029477 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Sun, 4 Dec 2011 14:31:52 -0500 (EST) Received: from amthrax by drake.mit.edu with local (Exim 4.76) (envelope-from ) id 1RXHmx-0002iw-Oc; Sun, 04 Dec 2011 14:31:51 -0500 From: Austin Clements To: notmuch@notmuchmail.org Subject: [PATCH 1/4] show: Pass notmuch_message_t instead of path to show_message_body. Date: Sun, 4 Dec 2011 14:31:37 -0500 Message-Id: <1323027100-10307-2-git-send-email-amdragon@mit.edu> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1323027100-10307-1-git-send-email-amdragon@mit.edu> References: <1322446871-14986-1-git-send-email-amdragon@mit.edu> <1323027100-10307-1-git-send-email-amdragon@mit.edu> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNIsWRmVeSWpSXmKPExsUixCmqrLvy1G0/gxeb5Sxauz8zWVzd2s9u sWefl8X1mzOZHVg8zna3s3rcPc3lsXPWXXaPZ6tuMQewRHHZpKTmZJalFunbJXBlnPn6jamg TahizcaVjA2MV/m6GDk5JARMJGa8amKCsMUkLtxbz9bFyMUhJLCPUWJxx0NGCGc9o8SxyZuZ IZx7TBIbfy1gBGkREpjPKNFw3gfEZhPQkNi2fzlYXERAWmLn3dmsIDazQJ1E58Yz7F2MHBzC AuES9974gJgsAqoSD+Zbgpi8Ag4SZ097QNygIPHryCpWkDCngKPEzVuWEHvKJe627WebwMi/ gJFhFaNsSm6Vbm5iZk5xarJucXJiXl5qka6hXm5miV5qSukmRnCYSfLsYHxzUOkQowAHoxIP b+aJW35CrIllxZW5hxglOZiURHmfnLztJ8SXlJ9SmZFYnBFfVJqTWnyIUYKDWUmEN2MxUI43 JbGyKrUoHyYlzcGiJM57cIeDn5BAemJJanZqakFqEUxWhoNDSYJ3NchQwaLU9NSKtMycEoQ0 EwcnyHAeoOFgNbzFBYm5xZnpEPlTjIpS4rwnQRICIImM0jy4XlgaeMUoDvSKMO8rkCoeYAqB 634FNJgJaLBi4w2QwSWJCCmpBsZG1XmXp7oKhUWta7vYV3rpidWiZzWCW0O/bNDLUEy/fKb4 39YL86UXz5+01GmjdS/brCezlKUyRPQn1bEdrn51zPFXzNoFpeu3WjCrMjMszjW5LvG22rWk dWJn9eVlE2/5/lDNWFZo3jY7ovP2zBNrGZ5yZLE1LH315duGxwHmVTu1PzKvbCpVYinOSDTU Yi4qTgQA7VWbgt4CAAA= Cc: dkg@fifthhorseman.net X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Dec 2011 19:31:58 -0000 In addition to simplifying the code, we'll need the notmuch_message_t* in show_message_body shortly. --- notmuch-client.h | 2 +- notmuch-reply.c | 3 +-- notmuch-show.c | 3 +-- show-message.c | 3 ++- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/notmuch-client.h b/notmuch-client.h index b50cb38..d7fb6ee 100644 --- a/notmuch-client.h +++ b/notmuch-client.h @@ -162,7 +162,7 @@ char * query_string_from_args (void *ctx, int argc, char *argv[]); notmuch_status_t -show_message_body (const char *filename, +show_message_body (notmuch_message_t *message, const notmuch_show_format_t *format, notmuch_show_params_t *params); diff --git a/notmuch-reply.c b/notmuch-reply.c index 7ac879f..f8d5f64 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -546,8 +546,7 @@ notmuch_reply_format_default(void *ctx, notmuch_message_get_header (message, "date"), notmuch_message_get_header (message, "from")); - show_message_body (notmuch_message_get_filename (message), - format, params); + show_message_body (message, format, params); notmuch_message_destroy (message); } diff --git a/notmuch-show.c b/notmuch-show.c index 603992a..1dee3aa 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -753,8 +753,7 @@ show_message (void *ctx, } if (format->part_content) - show_message_body (notmuch_message_get_filename (message), - format, params); + show_message_body (message, format, params); if (params->part <= 0) { fputs (format->body_end, stdout); diff --git a/show-message.c b/show-message.c index d83f04e..09fa607 100644 --- a/show-message.c +++ b/show-message.c @@ -175,7 +175,7 @@ show_message_part (GMimeObject *part, } notmuch_status_t -show_message_body (const char *filename, +show_message_body (notmuch_message_t *message, const notmuch_show_format_t *format, notmuch_show_params_t *params) { @@ -183,6 +183,7 @@ show_message_body (const char *filename, GMimeParser *parser = NULL; GMimeMessage *mime_message = NULL; notmuch_status_t ret = NOTMUCH_STATUS_SUCCESS; + const char *filename = notmuch_message_get_filename (message); FILE *file = NULL; show_message_state_t state; -- 1.7.5.4