Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id AC991429E20 for ; Sun, 8 May 2011 15:02:01 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XS8K9qf6PM03 for ; Sun, 8 May 2011 15:02:01 -0700 (PDT) Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 2BB54431FB5 for ; Sun, 8 May 2011 15:02:01 -0700 (PDT) Received: by qyg14 with SMTP id 14so3979062qyg.5 for ; Sun, 08 May 2011 15:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=jLFL+tYIrM3i0s77qqoz4IIV2wu5v1UVhLk2nA1JaUk=; b=syUPO+LtxKTIFTFQr7SptE+y6TpwD8STrRZQPt75yDMBZgsUGQOsH+XNWeXI7kXe+O VNcm8NsB3B6A0CJoXeJn6eZ46wHI9VrV5t6zio7+8SS/7eTbZtV6+H9lYNFOnHCgfhjr DHLmuIYlr9FaAe2C/C5sOVsgPW9PuKomanY7g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=SXKetYBmFcbGWrYMUfAxYOh/IGv1Yp6VBcnNNR361ahsBsW44dO5tUavUBZvsnWNwt byj19cLooYd7QZ6GnTZY0KyLgm3zoruQBnYxt0hxO2u9e9hcoMD+svEkoxW1FeMkG01g weYBGzsW96Sa0qbvmyXUoVnDLdLjT9j4Z98Hs= MIME-Version: 1.0 Received: by 10.229.251.13 with SMTP id mq13mr4515856qcb.36.1304892120245; Sun, 08 May 2011 15:02:00 -0700 (PDT) Sender: amdragon@gmail.com Received: by 10.229.233.17 with HTTP; Sun, 8 May 2011 15:02:00 -0700 (PDT) In-Reply-To: <877ha06epi.fsf@eve.chaoflow.net> References: <87liyjgvyw.fsf@servo.factory.finestructure.net> <1304889273-24560-1-git-send-email-flo@chaoflow.net> <1304889273-24560-2-git-send-email-flo@chaoflow.net> <877ha06epi.fsf@eve.chaoflow.net> Date: Sun, 8 May 2011 18:02:00 -0400 X-Google-Sender-Auth: ZaOdP_KmC7MjcWp_Dqrh9LXjdJk Message-ID: Subject: Re: [PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search From: Austin Clements To: Florian Friesdorf Content-Type: text/plain; charset=ISO-8859-1 Cc: notmuch@notmuchmail.org, Andreas Amann X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 May 2011 22:02:01 -0000 On Sun, May 8, 2011 at 5:54 PM, Florian Friesdorf wrote: > On Sun, 8 May 2011 17:40:54 -0400, Austin Clements wrote: >> Also, existing code conventionally uses a variable named "local" >> for function-level talloc contexts such as your ctx_quote. > > In notmuch-search.c there is no variable named "local", in the other > functions its also named ctx_quote. Should I rename all ctx_quote to > "local"? Huh, sure enough. Looks like the library uses "local" consistently, but the CLI uses ctx_quote multiple times and "local" appears only once, so, yeah, stick with ctx_quote.