Date: Fri, 03 Oct 2014 11:41:12 -0700
From: Ian Main <imain@stemwinder.org>
To: David Bremner <david@tethera.net>, David Bremner <david@tethera.net>,
	notmuch@notmuchmail.org
Message-ID: <542eedc8cb635_ed1ddfe8cd0@ovo.mains.priv.notmuch>
In-Reply-To: <87r3ypr6cm.fsf@maritornes.cs.unb.ca>
References: <1412286796-27479-1-git-send-email-imain@stemwinder.org>
	<1412293635-31273-1-git-send-email-imain@stemwinder.org>
	<87r3ypr6cm.fsf@maritornes.cs.unb.ca>
Subject: Re: [PATCH v2] VIM: Use notmuch CLI for config
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: list

David Bremner wrote:
> Ian Main <imain@stemwinder.org> writes:
> 
> > This patch switches from reading .notmuch-config directly to using
> > the CLI the same way that emacs does it.  It actually uses less code
> > and is probably less error prone.
> >
> >     Ian
> 
> The general approach seems sane; it seems quite brittle to read the
> config file directly. I notice there is not really any error handling;
> OTOH, as far as I can read Ruby, there is not any in the previous
> version either.  Technically, this does add a dependency of the vim
> client on the CLI that did not exist before. Personally I don't find
> this onerous (even notmuch-vim users need "notmuch new", except in
> rather unusual circumstances.).
> 
> I'd like feedback/testing from actual vim interface users before
> merging.

I am actually just following suit on what was already being done.
The Vim client was already calling out to notmuch CLI for other things,
eg:

   system "notmuch show --format=mbox id:#{m.message_id} > #{mbox} && #{cmd}"

Is used to save the email for display in another program.  Also with no
error checking.  I think basically we are relying on rubys exception handling
to display errors to the user.. not the best idea but it is functional.

I could add a check for 'notmuch' binary.. especially there because loading
the config is the first thing that is done on startup.

    Ian