From: Mark Walters <markwalters1009@gmail.com>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v1 0/3] emacs: Allow saving of threads and messages
In-Reply-To: <1399623743-30478-1-git-send-email-dme@dme.org>
References: <1399623743-30478-1-git-send-email-dme@dme.org>
User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Fri, 09 May 2014 13:05:09 +0100
Message-ID: <877g5vb1je.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


Hi

I think the functionality is well worth having ("|" cat - > a-file is
ugly!). However, I am not sure about this approach.

The first two patches are fine, although I think I like constructing a
query then quoting rather than quoting bits of a query and bolting them
together (even the both work).

My concern is that the current approach gives the user no warning if
they are about to overwrite an existing file, and that this is true
regardless of any emacs settings. 

Could we do these saves by loading into a temporary buffer and then
using the normal emacs save buffer functions? That way we get the
benefit of emacs's normal query-overwrite, and respect any user
customizations of that.

The only potential problem is to make sure we don't do any accidental
charset conversion. I guess this functionality is probably easy to test
at least!

Best wishes

Mark



On Fri, 09 May 2014, David Edmondson <dme@dme.org> wrote:
> emacs: Allow saving of threads and messages
>
> Similar to the pipe (|) support, allow saving of threads and messages.
>
>
> David Edmondson (3):
>   emacs: Fix indentation.
>   emacs: Minor re-work of `notmuch-show-pipe-message'
>   emacs: Add `notmuch-show-save-message' to save messages
>
>  emacs/notmuch-show.el | 161 ++++++++++++++++++++++++++++----------------------
>  1 file changed, 91 insertions(+), 70 deletions(-)
>
> -- 
> 2.0.0.rc0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch