Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 0F9106DE02A9
 for <notmuch@notmuchmail.org>; Sun,  8 May 2016 01:25:37 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.595
X-Spam-Level: 
X-Spam-Status: No, score=0.595 tagged_above=-999 required=5 tests=[AWL=-0.057,
  SPF_NEUTRAL=0.652] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id vgyYkMpJ5Prb for <notmuch@notmuchmail.org>;
 Sun,  8 May 2016 01:25:28 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
 by arlo.cworth.org (Postfix) with ESMTP id 9BD116DE0217
 for <notmuch@notmuchmail.org>; Sun,  8 May 2016 01:25:28 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
 by guru.guru-group.fi (Postfix) with ESMTP id 2506B1000B3;
 Sun,  8 May 2016 11:25:24 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: v4 of libconfig / single argument date / named query patches
In-Reply-To: <1462665889-17121-1-git-send-email-david@tethera.net>
References: <1462665889-17121-1-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.22+9~gb26b5ad (http://notmuchmail.org) Emacs/24.3.1
 (x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
 !)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sun, 08 May 2016 11:25:23 +0300
Message-ID: <m2oa8h2byk.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 08 May 2016 08:25:37 -0000

On Sun, May 08 2016, David Bremner <david@tethera.net> wrote:

> This obsoletes
>
>      id:1462065879-29860-1-git-send-email-david@tethera.net

looks pretty good & tests pass. one problem though, rest are nits:


;; This buffer is for notes you don't want to save, and for Lisp evaluation.
;; If you want to create a file, visit that file with C-x C-f,
;; then enter the text in that file's own buffer.


*** in id:1462665889-17121-2-git-send-email-david@tethera.net

+                  -DHAVE_XAPIAN_FIELD_PROCESSOR=\$(HAVE_XAPIAN_PROCESSOR) \\

build gives compile /warning/ there, unfortunately this is not fatal and
therefore can go unnoticed. -Wundef would do the same, complain about
undefined macro but would not be fatal.

then, some more nits:


*** id:1462665889-17121-4-git-send-email-david@tethera.net

+_notmuch_config_list_options () {


*** id:1462665889-17121-8-git-send-email-david@tethera.net

+typedef enum dump_includes {
+    DUMP_INCLUDE_TAGS=1,
+    DUMP_INCLUDE_CONFIG=2,
+} dump_include_t;

print_dump_header () has some empty lines before closing '}'


*** id:1462665889-17121-9-git-send-email-david@tethera.net

+process_config_line(notmuch_database_t *notmuch, const char* line){

+    val_p = strtok_len_c(key_p+key_len, delim, &val_len);                      



+    int include=0;


*** id:1462665889-17121-12-git-send-email-david@tethera.net

+/* query-fp.cc -  "query:" field processor glue glue


id:1462665889-17121-13-git-send-email-david@tethera.net

+_notmuch_config_list_built_with () {