To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH 1/3] emacs: Stop the `truncate-string-to-width' madness.
In-Reply-To: <20120128050958.GA17991@mit.edu>
References: <1327496913-4946-1-git-send-email-dme@dme.org>
	<1327499314-7887-1-git-send-email-dme@dme.org>
	<1327499314-7887-2-git-send-email-dme@dme.org>
	<20120128050958.GA17991@mit.edu>
User-Agent: Notmuch/0.11+122~g97bdcf6 (http://notmuchmail.org) Emacs/24.0.92.1
	(x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Mon, 30 Jan 2012 09:16:24 +0000
Message-ID: <cunr4yhim8n.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sat, 28 Jan 2012 00:09:58 -0500, Austin Clements <amdragon@MIT.EDU> wrot=
e:
> Quoth David Edmondson on Jan 25 at  1:48 pm:
> > There's no need to call `truncate-string-to-width' twice in this code
> > path.
>=20
> LGTM if what I point out below is okay.  Technically this changes the
> behavior of this code, but what it did before was obviously wrong (if
> you do roll a new version, I'd mention this in the commit message; but
> no need to do that just for this).
>=20
> > ---
> >  emacs/notmuch.el |   14 ++++++--------
> >  1 files changed, 6 insertions(+), 8 deletions(-)
> >=20
> > diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> > index 3ec0816..3f6b977 100644
> > --- a/emacs/notmuch.el
> > +++ b/emacs/notmuch.el
> > @@ -441,18 +441,16 @@ Complete list of currently available key bindings:
> >    (interactive "P")
> >    (let ((thread-id (notmuch-search-find-thread-id))
> >  	(subject (notmuch-search-find-subject)))
> > +
> > +    (if (string-match "^[ \t]*$" subject)
> > +	(setq subject "[No Subject]"))
> > +
>=20
> Is subject necessarily a string at this point?  Previously this only
> ran if the code determined there was a thread at point.

No, it's a bug. It's fixed in the third patch, but should be fixed here
as well.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk8mX+gACgkQaezQq/BJZRbPSACfdMZJjKihAzVShy5d+6ayyxVU
KqwAnjMzV9EQXm52jm9wJDPDbZ/nPceg
=eweS
-----END PGP SIGNATURE-----
--=-=-=--