From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] contrib: pick: bugfix for pick splitting the window
	excessively
In-Reply-To: <1355084249-17523-1-git-send-email-markwalters1009@gmail.com>
References: <1355084249-17523-1-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.14+157~g146ede5 (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-pc-linux-gnu)
Date: Mon, 10 Dec 2012 10:26:42 -0800
Message-ID: <87fw3dbw65.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sun, Dec 09 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> Previously if you carried on past the last message in a pick view pick
> would get confused and `forget' about the split pane and would try and
> re-split when moving up again. This was due to faulty logic in
> notmuch-pick-show-message: something that should have been in the (when m=
essage)
> clause was not.
>
> Thanks to jrollins for the bug report.
> ---
>
> A simple bugfix: I can reproduce the bug that jrollins found and this
> fixes it for both of us.
>
> Best wishes
>
> Mark
>
>  contrib/notmuch-pick/notmuch-pick.el |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/=
notmuch-pick.el
> index 63776d5..a46ef6e 100644
> --- a/contrib/notmuch-pick/notmuch-pick.el
> +++ b/contrib/notmuch-pick/notmuch-pick.el
> @@ -402,8 +402,8 @@ Does NOT change the database."
>        (with-selected-window notmuch-pick-message-window
>  	(setq current-prefix-arg '(4))
>  	(setq buffer (notmuch-show id nil nil nil)))
> -      (notmuch-pick-tag-update-display (list "-unread")))
> -    (setq notmuch-pick-message-buffer buffer)))
> +      (notmuch-pick-tag-update-display (list "-unread"))
> +      (setq notmuch-pick-message-buffer buffer))))
>=20=20
>  (defun notmuch-pick-show-message-out ()
>    "Show the current message (in whole window)."

Sorry, I should have responded to this immediately.  This is a bug fix,
and I've tested it and it works perfectly.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJQxiliAAoJEO00zqvie6q8VPkP/1l82GOEFf+d2SGEVRiw+3h4
md3z+SJfcagY1XpGdxo2/Q0UqkrjZ8m4rJdmkCYOseBosGqaF6nXNCKoikE/4a2b
pY1ryqZIK4dtsiUF5UuQxRJ6ppWPKDrycyoEQtxR0nzD6grSfYvsLeUXDoNn8CDL
SziONi1L18hCvLoNeMQ/uZEbX2C0dRbvn+tOwtDrjJeGPu8TsN3rqDkg0/ihekil
oRaFd4nxVrqRhOTi9RS8VsCQFZsl+vfG2og5d8RFvUWTvSDdlAVKCKBGt0LRseS5
4ZL2bTcvxzaeBe3b5vV2224RPxNsTPh6yzJHJGmbe2LEmYUuzlteniuikW4pBz0G
fW+DNesTSUCHmjWsq4hTEe4LTiJes1QQ+nm0Yt59hR8l0FIOyixZH8Gj8BuoL7Zw
8dGV27nBdE2gPt+TSAzEMMQEBXMnGHmu/CAnO8bK4uXNDGpDKoTaaVOWhh4h1NBN
07zelTM6GOtmpPFBGh/zjV2lbqujTeq3kTetiNmpFryfvRYCXk3TeOEBz6bUUl29
LHvCHdqkBj3hP3dTk1KbZvEW9A4bwjEkiJBHs4oCDPE5xXlHk3Lf8qsM38tEmiKH
gC7iT3VCjt7AICfeAm80qcAUUwAX0dSLqgGRMHHPgLBHGJGht5iIWWp4kn2Xwl8c
MxdNGDNTQWe2f/POkEVK
=sAE7
-----END PGP SIGNATURE-----
--=-=-=--