To: Daniel Schoepe <daniel@schoepe.org>,
 James Vasile <james@hackervisions.org>,	notmuch@notmuchmail.org
Subject: Re: [notmuch] [PATCH] Calls to notmuch get queued and executed
	asynchronously.
In-Reply-To: <87wrbykr13.fsf@gilead.invalid>
References: <87vddnlxos.wl%james@hackervisions.org>
	<87wrbykr13.fsf@gilead.invalid>
User-Agent: Notmuch/0.10.2+151~gbf1dc2b (http://notmuchmail.org)
	Emacs/24.0.92.1 (x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Fri, 30 Dec 2011 10:52:17 +0000
Message-ID: <cun4nwi8h7i.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Fri, 21 Oct 2011 22:50:48 +0200, Daniel Schoepe <daniel@schoepe.org> wro=
te:
> On Tue, 23 Feb 2010 11:32:51 -0500, James Vasile <james@hackervisions.org=
> wrote:
> > Added notmuch-enqueue-asynch to replace calls to
> > notmuch-call-notmuch-process.  Calls to notmuch are then queued and
> > executed asynchronously.  If the db is busy and we get an error saying
> > it was locked, keep trying until the db is no longer busy.  Errors go
> > in a buffer as per usual.
>=20
> I discovered this patch a while ago and it almost applies cleanly (the
> conflicts are easy to fix though) and it has made the emacs UI for
> notmuch _much_ more responsive and enjoyable for me. As discussed on
> IRC, issues such as where to handle retries in case the database is
> locked should probably be handled in the notmuch binary instead of each
> UI.
>
> I am however unaware of any patches to accomplish that and with the pace
> of development / patch reviews the way it is at the moment, this patch
> is a really helpful stop-gap (performing calls to notmuch asynchronously
> is useful independently of where concurrency issues are handled though)
> for me. If someone else agrees, I can fix the conflicts for this patch
> and send the revised version to the list.

It would be good to have an updated version of this patch if it is still
considered useful, though I don't suffer particularly from lag in the
emacs UI.

One concern is the string searching on the output of 'notmuch' to detect
the database locked condition. Perhaps 'notmuch' could be made to
return a specific error code in that case, negating the need to string
match?

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk79l+EACgkQaezQq/BJZRafjACbBou8X815OQ4Hbd9vhBWH1FFX
MDQAnRThDAbfCA1QAHEzFh3aX/hg0CGl
=NRqk
-----END PGP SIGNATURE-----
--=-=-=--