Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2AD8F431FBD for ; Sun, 13 Apr 2014 05:49:22 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D+GHuE2nmOX3 for ; Sun, 13 Apr 2014 05:49:13 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id A4E2B431FBC for ; Sun, 13 Apr 2014 05:49:13 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 2304310008F; Sun, 13 Apr 2014 15:49:07 +0300 (EEST) From: Tomi Ollila To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] test: use test_expect_equal for PATH test, update message In-Reply-To: <1397392969-8735-1-git-send-email-david@tethera.net> References: <1397392969-8735-1-git-send-email-david@tethera.net> User-Agent: Notmuch/0.17+184~g85e3db6 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Apr 2014 12:49:22 -0000 On Sun, Apr 13 2014, David Bremner wrote: > - The old test was quite impossible to debug; the new one shows the difference > between the two directories, if any. > > - "repository" doesn't make sense for out of tree builds. Or tarball > builds, for that matter. > --- Looks better than the old one. +1 Tomi > > I was tracking down a weird issue with out of tree builds. I didn't > find the issue (it may have just been cruft from a previously broken > build). In any case, I think the patch is a small improvement. > > test/T000-basic.sh | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/test/T000-basic.sh b/test/T000-basic.sh > index 9c94b62..ebbb6d2 100755 > --- a/test/T000-basic.sh > +++ b/test/T000-basic.sh > @@ -86,8 +86,9 @@ test_expect_success \ > 'NOTMUCH_CONFIG is set and points to an existing file' \ > 'test -f "${NOTMUCH_CONFIG}"' > > -test_expect_success \ > - 'PATH is set to this repository' \ > - 'test "`echo $PATH|cut -f1 -d: | sed -e 's,/test/valgrind/bin$,,'`" = "`dirname ${TEST_DIRECTORY}`"' > +test_begin_subtest 'PATH is set to build directory' > +test_expect_equal \ > + "$(dirname ${TEST_DIRECTORY})" \ > + "$(echo $PATH|cut -f1 -d: | sed -e 's,/test/valgrind/bin$,,')" > > test_done > -- > 1.9.1 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch