Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 96FA3431FB6 for ; Sat, 7 Apr 2012 15:09:29 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SEwjd6o-r+lA for ; Sat, 7 Apr 2012 15:09:29 -0700 (PDT) Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU [18.9.25.12]) by olra.theworths.org (Postfix) with ESMTP id 03AC3431FAE for ; Sat, 7 Apr 2012 15:09:28 -0700 (PDT) X-AuditID: 1209190c-b7fad6d000000920-a9-4f80bb16b1a0 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP id 20.54.02336.61BB08F4; Sat, 7 Apr 2012 18:09:26 -0400 (EDT) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q37M9QdL026297; Sat, 7 Apr 2012 18:09:26 -0400 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q37M9OqT019416 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Sat, 7 Apr 2012 18:09:25 -0400 (EDT) Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) (envelope-from ) id 1SGdox-0003RD-V5; Sat, 07 Apr 2012 18:09:24 -0400 Date: Sat, 7 Apr 2012 18:09:23 -0400 From: Austin Clements To: Mark Walters Subject: Re: [PATCH v4 0/6] Move --no-exclude to --exclude=(true|false|flag) Message-ID: <20120407220923.GF32065@mit.edu> References: <1333815008-24668-1-git-send-email-markwalters1009@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1333815008-24668-1-git-send-email-markwalters1009@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IR4hTV1hXb3eBvsHmNvsXquTwW12/OZHZg 8tg56y67x7NVt5gDmKK4bFJSczLLUov07RK4Mm7vWMpe0MVa0TFvPlsDYxtLFyMnh4SAiUTT jk9QtpjEhXvr2boYuTiEBPYxShz6vYkZwlnPKLHvewdU5gSTxMdD26CcJYwSTzbNZALpZxFQ kTi7az8ziM0moCGxbf9yRhBbREBH4vahBewgNrOAtMS3381g9cICPhI7Jp8Dsjk4eIFqps22 BwkLCXhKXJ54kQ3E5hUQlDg58wkLRKuWxI1/L8HKQcYs/8cBEuYU8JK4fL0DrFwU6IIpJ7ex TWAUmoWkexaS7lkI3QsYmVcxyqbkVunmJmbmFKcm6xYnJ+blpRbpGurlZpbopaaUbmIEB7Uk zw7GNweVDjEKcDAq8fAG8dX7C7EmlhVX5h5ilORgUhLl7dne4C/El5SfUpmRWJwRX1Sak1p8 iFGCg1lJhHfNFKAcb0piZVVqUT5MSpqDRUmcV0XrnZ+QQHpiSWp2ampBahFMVoaDQ0mC12YX UKNgUWp6akVaZk4JQpqJgxNkOA/Q8EyQGt7igsTc4sx0iPwpRkUpcV5jkIQASCKjNA+uF5Z0 XjGKA70izOsBUsUDTFhw3a+ABjMBDa55VQ8yuCQRISXVwMjp8Fh36i1uR8bDF24d686WviIi u2b/O/vI0hNzf1auiFF/drjxSLTOzf9vI7YFhzKJbnL6v3fFO1dTr7oJDEn6bJPKM9ZxNc8u qy58wc1j8kzmmPhTk7UKq6I2eOwWnGT+3SF86Yu5uZmGW8/zZmn+n+vuNt/08ITefWkbN8/N Xyd3skd4qagSS3FGoqEWc1FxIgDRqXxYFQMAAA== Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Apr 2012 22:09:29 -0000 LGTM. If for some reason you roll another version, you should update the commit message on the test patch, but that's obviously not enough to hold this series up. Quoth Mark Walters on Apr 07 at 5:10 pm: > This is version 4 of the exclude= patch set. Version 3 was at [1]. > > The only changes relative to version 3 are in the tests. As suggested > by jrollins [2] I have added some systematic count and show tests and > moved all the exclude tests to the file test/excludes. > > Best wishes > > Mark > > [1] id:"1333716551-29153-1-git-send-email-markwalters1009@gmail.com" > [2] id:"877gxs7ryv.fsf@servo.finestructure.net"