Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 2E9666DE111A for ; Sun, 11 Oct 2015 09:46:05 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 1.139 X-Spam-Level: * X-Spam-Status: No, score=1.139 tagged_above=-999 required=5 tests=[AWL=-0.257, SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id khraIwCbhQ30 for ; Sun, 11 Oct 2015 09:46:03 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by arlo.cworth.org (Postfix) with ESMTP id D6C396DE100F for ; Sun, 11 Oct 2015 09:46:02 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 8D45310005B; Sun, 11 Oct 2015 19:45:56 +0300 (EEST) From: Tomi Ollila To: David Bremner , Jani Nikula , notmuch@notmuchmail.org Subject: Re: V2 of directory delete patches In-Reply-To: <1444480039-8530-1-git-send-email-david@tethera.net> References: <591f5298ac3f2c79f727cac8bad1251830b28a3c.1443213654.git.jani@nikula.org> <1444480039-8530-1-git-send-email-david@tethera.net> User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Oct 2015 16:46:05 -0000 On Sat, Oct 10 2015, David Bremner wrote: > Changes since id:cover.1443213654.git.jani@nikula.org > > - tidy commit messages > - update docs in lib/notmuch.h > - make an executive decision not to push _remove_directory into lib > for now; it can always be a new api layer later. > - unmark fixed tests > - wrap xapian calls in try/catch Looks good to me. tests pass. Tomi