From: Carl Worth <cworth@cworth.org>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] new: Don't update DB mtime if FS mtime equals
	wall-clock time.
In-Reply-To: <87wrg4696u.fsf@yoom.home.cworth.org>
References: <1309331455-19584-1-git-send-email-amdragon@mit.edu>
	<87wrg4696u.fsf@yoom.home.cworth.org>
User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1
	(i486-pc-linux-gnu)
Date: Wed, 29 Jun 2011 07:41:12 -0700
Message-ID: <87ei2c66pj.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: amdragon@mit.edu
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Wed, 29 Jun 2011 06:47:37 -0700, Carl Worth <cworth@cworth.org> wrote:
> On Wed, 29 Jun 2011 03:10:54 -0400, Austin Clements <amdragon@MIT.EDU> wr=
ote:
> > +     * XXX Bug workaround: If this is a new directory, we *must*
> > +     * update the mtime; otherwise the next run will see the 0 mtime
...
> I like to reserve "XXX" as an indication that some further work is
> necessary.

Reading your other mail now, I see that there are bugs here and that you
do want to eliminate the new_directory optimization. That wasn't clear
to me from the comment above.

So the XXX is probably fine, but could perhaps give a little more
indication of what could be done to eliminate the bug.

=2DCarl

=2D-=20
carl.d.worth@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk4LOYgACgkQ6JDdNq8qSWjyxwCfehV9WJ8RrWY946e8e5jhP4D7
JXAAn1rInHJuZNobGWAPOieEjKpIwKn9
=ZUPV
-----END PGP SIGNATURE-----
--=-=-=--