From: Jameson Rollins <jrollins@finestructure.net>
To: Notmuch Mail list <notmuch@notmuchmail.org>
Subject: Re: [PATCH] Remove bcc header from notmuch reply.
In-Reply-To: <87r5pcad5v.fsf@servo.finestructure.net>
References: <87r5pcad5v.fsf@servo.finestructure.net>
User-Agent: Notmuch/0.3-12-g78345c5 (http://notmuchmail.org) Emacs/23.1.1
	(i486-pc-linux-gnu)
Date: Wed, 28 Apr 2010 17:33:18 -0400
Message-ID: <87d3xjxnxd.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

Notmuch reply should not be Bcc'ing the sender by default.  This is
not the appropriate way to save copies of sent mail (which should
probably be handled by an Fcc header) and it doesn't give the user the
option to not be bcc'd.  This is really something that should be
handled by the reader UI.  For instance, emacs message-mode can easily
be configured to add Bcc's if the user wishes.
=2D--
Now that we finally have good built-in fcc support, we can finally get
rid of the annoying bcc in notmuch-reply.

This is a resubmit of an old patch that has been rebased against the
current head of cworth/master.

 notmuch-reply.c |    9 +--------
 1 files changed, 1 insertions(+), 8 deletions(-)

diff --git a/notmuch-reply.c b/notmuch-reply.c
index fd1de3b..856d5e9 100644
=2D-- a/notmuch-reply.c
+++ b/notmuch-reply.c
@@ -267,8 +267,7 @@ add_recipients_from_message (GMimeMessage *reply,
     } reply_to_map[] =3D {
 	{ "reply-to", "from", GMIME_RECIPIENT_TYPE_TO  },
 	{ "to",         NULL, GMIME_RECIPIENT_TYPE_TO  },
=2D	{ "cc",         NULL, GMIME_RECIPIENT_TYPE_CC  },
=2D	{ "bcc",        NULL, GMIME_RECIPIENT_TYPE_BCC }
+	{ "cc",         NULL, GMIME_RECIPIENT_TYPE_CC  }
     };
     const char *from_addr =3D NULL;
     unsigned int i;
@@ -481,9 +480,6 @@ notmuch_reply_format_default(void *ctx, notmuch_config_=
t *config, notmuch_query_
 	g_mime_object_set_header (GMIME_OBJECT (reply),
 				  "From", from_addr);
=20
=2D	g_mime_object_set_header (GMIME_OBJECT (reply), "Bcc",
=2D			   notmuch_config_get_user_primary_email (config));
=2D
 	in_reply_to =3D talloc_asprintf (ctx, "<%s>",
 			     notmuch_message_get_message_id (message));
=20
@@ -558,9 +554,6 @@ notmuch_reply_format_headers_only(void *ctx, notmuch_co=
nfig_t *config, notmuch_q
=20
 	(void)add_recipients_from_message (reply, config, message);
=20
=2D	g_mime_object_set_header (GMIME_OBJECT (reply), "Bcc",
=2D			   notmuch_config_get_user_primary_email (config));
=2D
 	reply_headers =3D g_mime_object_to_string (GMIME_OBJECT (reply));
 	printf ("%s", reply_headers);
 	free (reply_headers);
=2D-=20
1.7.0

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJL2KmeAAoJEO00zqvie6q8V3YP/2DTdhIE8/T9gXgplKVpvVNw
G+YthrYTZN0yzLTJiU16zXIIYxsXVpn+Qf1wdDYKck341sWnTxSBY/F6DWzFBB3B
Ubq7pRHjUmaz/JmSes6uwSdgb/dLBz+dVmZEPkeg36IFLasMNoEinWjXdfgDT8+C
h4qlzj7XCkU6Et6bi+SIztgCa5P89+CEcAAVFalxqt02JmMw5tJNNGacucCdAcFv
VbgghjQYaXE4Jw5n8mT+IazZJg/O98prV5kgGJisnKGfTVizaipD/4UJ82fnSlI8
ovdBbaZWFEgrK0+OEGkVlhSn5aj6dTckbKw83Sm/2jBgQqn4gF1CDDS2G+f0kg4X
Z/QKm523pAiay2AU9BIUlT2yKO0gKDWtdEPZJzBvUWo8Mml/DviSgL9UbZSNAUK7
ajHLUBRVW60rhNiSPUEyzSppikBMsgtsKrbxuo5FTRLRU9NG1ty0oqXCvqyP/h3Z
DoaXWDe6BX/LlzpZ8oDkw5G8LDOkGKeyHYow24nEhYRviUWq3hrMP3p2LJZSXFj3
THx7g3HxlX+BbP8dY65dR08tXBAYY+xoOIYKl6kTY0ngkkKDje1doce686G5ghuw
wo//LmOsPuCLYcv953KUoFLzEGhJfAG7reeM/8Qgta3B9BQu6cTb38JKLQygjUTw
rc7o6QTIsFTNcQzemAa6
=klOe
-----END PGP SIGNATURE-----
--=-=-=--