Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id A0F626DE1989 for ; Tue, 7 Apr 2015 03:22:27 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.443 X-Spam-Level: X-Spam-Status: No, score=0.443 tagged_above=-999 required=5 tests=[AWL=0.443] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5yTA_CVGVWVX for ; Tue, 7 Apr 2015 03:22:25 -0700 (PDT) Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net [87.98.215.224]) by arlo.cworth.org (Postfix) with ESMTPS id 5DA6E6DE1950 for ; Tue, 7 Apr 2015 03:22:25 -0700 (PDT) Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim 4.80) (envelope-from ) id 1YfQcq-0000QS-QS; Tue, 07 Apr 2015 10:20:56 +0000 Received: (nullmailer pid 25482 invoked by uid 1000); Tue, 07 Apr 2015 10:20:38 -0000 From: David Bremner To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [Patch v2 4/4] cli: add standard option processing to config and setup In-Reply-To: <87vbh8qu2s.fsf@qmul.ac.uk> References: <87d23ixnr7.fsf@maritornes.cs.unb.ca> <1428322958-2887-1-git-send-email-david@tethera.net> <1428322958-2887-5-git-send-email-david@tethera.net> <87vbh8qu2s.fsf@qmul.ac.uk> User-Agent: Notmuch/0.19+96~g703c8f9 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Tue, 07 Apr 2015 19:20:38 +0900 Message-ID: <87vbh8gryh.fsf@maritornes.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2015 10:22:27 -0000 Mark Walters writes: > > Why "setup" here rather than argv[0] or similar? It seems inconsistent > with the other cases. > > Best wishes > > Mark You're right this deserves a comment. notmuch_setup_command is actually called with argv=NULL (hence the unused (char * argv). The argument types are constrained by the fact we use a table of function pointers to dispatch. d