Return-Path: <david@tethera.net>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 5DCDA431FBD
	for <notmuch@notmuchmail.org>; Wed, 16 Jul 2014 15:36:45 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 82E3RiFPkvjV for <notmuch@notmuchmail.org>;
	Wed, 16 Jul 2014 15:36:40 -0700 (PDT)
Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id A0F36431FC9
	for <notmuch@notmuchmail.org>; Wed, 16 Jul 2014 15:36:40 -0700 (PDT)
Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
	(envelope-from <david@tethera.net>)
	id 1X7XoV-0008VO-Ds; Wed, 16 Jul 2014 19:36:39 -0300
Received: (nullmailer pid 29658 invoked by uid 1000); Wed, 16 Jul 2014
	22:36:35 -0000
From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] dump: make dump take Xapian write lock
In-Reply-To: <1403554349-8888-1-git-send-email-markwalters1009@gmail.com>
References: <87zjhh67e7.fsf@qmul.ac.uk>
	<1403554349-8888-1-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.18.1+45~gf47eeac (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Wed, 16 Jul 2014 19:36:35 -0300
Message-ID: <878unt7wy4.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Jul 2014 22:36:45 -0000

Mark Walters <markwalters1009@gmail.com> writes:

> Dump currently only takes the read lock. Xapian can cope with some
> changes while maintaining a read snapshot but with more changes it
> fails. Currently notmuch just gives a xapian error.
>
> To avoid this we take the write lock when dumping. This prevents other
> notmuch processes from modifying the xapian database preventing this
> error.

pushed. This needs a NEWS item.

d